Skip to content

Tracing for eventhubs consumer and batch processor - #31197

Merged
lmolkova merged 11 commits into
Azure:mainfrom
lmolkova:eventhubs-receiver-tracing
Oct 31, 2022
Merged

Tracing for eventhubs consumer and batch processor#31197
lmolkova merged 11 commits into
Azure:mainfrom
lmolkova:eventhubs-receiver-tracing

Conversation

@lmolkova

Copy link
Copy Markdown

Fixes #28559, #28552

Similar to #30508 and enables the same user experience shown on the screenshots there

@azure-sdk

Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-messaging-eventhubs

@lmolkova
lmolkova force-pushed the eventhubs-receiver-tracing branch from f9b2435 to 2a99364 Compare October 4, 2022 03:59
@lmolkova
lmolkova requested review from heyams and ramthi as code owners October 4, 2022 03:59
@lmolkova
lmolkova force-pushed the eventhubs-receiver-tracing branch 2 times, most recently from 4c28182 to 1f3d870 Compare October 4, 2022 22:25
@check-enforcer

check-enforcer Bot commented Oct 4, 2022

Copy link
Copy Markdown

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@lmolkova
lmolkova force-pushed the eventhubs-receiver-tracing branch from b927f7d to 36fff65 Compare October 27, 2022 19:26
Comment thread sdk/core/azure-core-tracing-opentelemetry/README.md Outdated

@conniey conniey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lmolkova
lmolkova merged commit 5bdf09a into Azure:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQ] EventProcessorClient batch receive does not support tracing

3 participants