Skip to content

[CredScan] Refactor CredScan suppression to Java FakeCredentialInTests java files - #31685

Merged
mssfang merged 22 commits into
Azure:mainfrom
mssfang:CredScan
Nov 1, 2022
Merged

[CredScan] Refactor CredScan suppression to Java FakeCredentialInTests java files#31685
mssfang merged 22 commits into
Azure:mainfrom
mssfang:CredScan

Conversation

@mssfang

@mssfang mssfang commented Oct 24, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Remove some suppression and add the fake credentials in test file to replace CredScan suppressions

fixes: #30333

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added Azure.Core azure-core KeyVault Storage Storage Service (Queues, Blobs, Files) Cognitive - Text Analytics labels Oct 24, 2022
@azure-sdk

azure-sdk commented Oct 24, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

spring-cloud-azure-autoconfigure

@mssfang mssfang changed the title [CredScan] Fixed partial of credScan suppression [CredScan] Refactor CredScan suppression to Java FakeCredentialInTests java files Oct 26, 2022
@mssfang
mssfang marked this pull request as ready for review October 27, 2022 21:51
@weidongxu-microsoft weidongxu-microsoft mentioned this pull request Oct 28, 2022
Closed
alzimmermsft
alzimmermsft reviewed Oct 28, 2022
View reviewed changes
Comment thread eng/CredScanSuppression.json Outdated
Comment thread eng/CredScanSuppression.json Outdated
weshaggard
weshaggard reviewed Oct 28, 2022
View reviewed changes
Comment thread eng/CredScanSuppression.json Outdated
petrsvihlik
petrsvihlik approved these changes Oct 31, 2022
View reviewed changes

@petrsvihlik petrsvihlik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

azure-communication lgtm

@mssfang
mssfang merged commit 94e61ff into Azure:main Nov 1, 2022
@mssfang
mssfang deleted the CredScan branch November 1, 2022 16:18
@moarychan moarychan mentioned this pull request Nov 2, 2022
Merged
@vcolin7 vcolin7 mentioned this pull request Mar 4, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AikoBB AikoBB AikoBB approved these changes
@alzimmermsft alzimmermsft alzimmermsft approved these changes
@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes
@hallipr hallipr Awaiting requested review from hallipr
@benbp benbp Awaiting requested review from benbp benbp is a code owner
@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio
@haolingdong-msft haolingdong-msft Awaiting requested review from haolingdong-msft haolingdong-msft is a code owner
@XiaofeiCao XiaofeiCao Awaiting requested review from XiaofeiCao XiaofeiCao is a code owner
@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner
@bganapa bganapa Awaiting requested review from bganapa
@backwind1233 backwind1233 Awaiting requested review from backwind1233
@chenrujun chenrujun Awaiting requested review from chenrujun
@hui1110 hui1110 Awaiting requested review from hui1110
@Netyyyy Netyyyy Awaiting requested review from Netyyyy
@saragluna saragluna Awaiting requested review from saragluna saragluna is a code owner
@stliu stliu Awaiting requested review from stliu
@yiliuTo yiliuTo Awaiting requested review from yiliuTo
@moarychan moarychan Awaiting requested review from moarychan moarychan is a code owner
@fangjian0423 fangjian0423 Awaiting requested review from fangjian0423
@samvaity samvaity Awaiting requested review from samvaity samvaity is a code owner
@jaschrep-msft jaschrep-msft Awaiting requested review from jaschrep-msft
@ibrahimrabab ibrahimrabab Awaiting requested review from ibrahimrabab
@jairmyree jairmyree Awaiting requested review from jairmyree
@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 is a code owner
@schaabs schaabs Awaiting requested review from schaabs
@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner
@billwert billwert Awaiting requested review from billwert
@anuchandy anuchandy Awaiting requested review from anuchandy
@srnagar srnagar Awaiting requested review from srnagar
@lmolkova lmolkova Awaiting requested review from lmolkova
@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner
@JianpingChen JianpingChen Awaiting requested review from JianpingChen
@ankitarorabit ankitarorabit Awaiting requested review from ankitarorabit
@minnieliu minnieliu Awaiting requested review from minnieliu
@conniey conniey Awaiting requested review from conniey
@liukun-msft liukun-msft Awaiting requested review from liukun-msft
@geagin geagin Awaiting requested review from geagin
@maximrytych-ms maximrytych-ms Awaiting requested review from maximrytych-ms maximrytych-ms is a code owner
@ostoliarova-msft ostoliarova-msft Awaiting requested review from ostoliarova-msft
@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner
@weshaggard weshaggard Awaiting requested review from weshaggard
+2 more reviewers
@sima-zhu sima-zhu sima-zhu approved these changes
@petrsvihlik petrsvihlik petrsvihlik approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mssfang mssfang

Labels

Azure.Core azure-core Cognitive - Text Analytics KeyVault Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Milestone

2022-11

Development

Successfully merging this pull request may close these issues.

[CredScan] Revisit suppression placeholder list

9 participants

@mssfang @azure-sdk @g2vinay @weshaggard @petrsvihlik @AikoBB @sima-zhu @alzimmermsft @weidongxu-microsoft