Skip to content

Fixes to live tests. - #33861

Merged
vcolin7 merged 4 commits into
Azure:mainfrom
vcolin7:kv-certificates-fixes
Mar 6, 2023
Merged

Fixes to live tests.#33861
vcolin7 merged 4 commits into
Azure:mainfrom
vcolin7:kv-certificates-fixes

Conversation

@vcolin7

@vcolin7 vcolin7 commented Mar 4, 2023

Copy link
Copy Markdown
Member

Description

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@vcolin7 vcolin7 added KeyVault Client This issue points to a problem in the data-plane of the library. test-reliability Issue that causes tests to be unreliable labels Mar 4, 2023
@vcolin7 vcolin7 self-assigned this Mar 4, 2023
@vcolin7
vcolin7 requested review from g2vinay and samvaity as code owners March 4, 2023 02:30
@vcolin7

vcolin7 commented Mar 4, 2023

Copy link
Copy Markdown
Member Author

/azp run java - keyvault - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk

Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

@vcolin7

vcolin7 commented Mar 4, 2023

Copy link
Copy Markdown
Member Author

/azp run java - keyvault - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Comment thread sdk/keyvault/tests.yml
- ArmTemplateParameters=^(?!.*enableHsm.*true)
Canary:
SubscriptionConfiguration: $(sub-config-azure-cloud-test-resources)
Location: 'centraluseuap'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually working for you currently, though? @benbp filed an IcM ticket to make sure the App Service docker container for attestation is working correctly in Canary. It's been failing ever since we switched to the "new" docker container method instead of a shared resource. Are you using that docker container? Your test-resources.json should look like .NET's if so, which currently fails in Canary (eastus2euap or centraluseuap - but must be centraluseuap to support linux containers).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is deploying successfully, so that's a mystery why NET is failing.

I believe my onboarding ticket was successful, so I'm curious if NET works now? If not, perhaps something else is different or mis-configured?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for java - keyvault - tests-weekly they haven't run in a long time. Still using the old shared resource: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1244531&view=logs&j=2c650e94-8dba-5eb5-ae19-43d8491a0830&t=1827f084-241e-5105-dc6a-23213a15e367&l=250

For this run, I see no evidence it ever tried to deploy to canary. Only region I'm seeing in any of the 4 matrix runs are in westus.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tried it yet, the live tests pipeline I ran only deploys in the public cloud. Now that you mention it, I should look into where these tests for other clouds are run...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake, I was looking at the wrong deploy job results.

@vcolin7
vcolin7 merged commit 9993396 into Azure:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. KeyVault test-reliability Issue that causes tests to be unreliable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants