Skip to content

Fix typo - #31809

Merged
geagin merged 4 commits into
Azure:mainfrom
geagin:sb-fix-typo
Nov 2, 2022
Merged

Fix typo#31809
geagin merged 4 commits into
Azure:mainfrom
geagin:sb-fix-typo

Conversation

@geagin

@geagin geagin commented Oct 28, 2022

Copy link
Copy Markdown
Contributor

Description

Address #31637

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the Service Bus label Oct 28, 2022
@azure-sdk

Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

@geagin
geagin marked this pull request as ready for review October 28, 2022 09:19
Comment thread .vscode/cspell.json
"sdk/schemaregistry/azure-data-schemaregistry-apacheavro/**",
"sdk/servicebus/build/**",
"sdk/spring/scripts/**",
"sdk/servicebus/azure-messaging-servicebus/**",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we supposed to remove the library from spellcheck?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll ask in the original issue.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refer to other PRs, we should remove.

geagin and others added 3 commits November 1, 2022 08:37
…ure/messaging/servicebus/ServiceBusReceiverAsyncClient.java

Co-authored-by: Kishore Rajasekar <86338791+ki1729@users.noreply.github.com>
@geagin
geagin requested a review from ki1729 November 1, 2022 05:58

@ki1729 ki1729 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@geagin
geagin merged commit c36eeb6 into Azure:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants