Skip to content
Merged

Fix typo #31809

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .vscode/cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,6 @@
"sdk/schemaregistry/azure-data-schemaregistry-apacheavro/**",
"sdk/servicebus/build/**",
"sdk/spring/scripts/**",
"sdk/servicebus/azure-messaging-servicebus/**",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we supposed to remove the library from spellcheck?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll ask in the original issue.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refer to other PRs, we should remove.

"sdk/spring/spring-cloud-azure-actuator/**",
"sdk/spring/spring-cloud-azure-actuator-autoconfigure/**",
"sdk/spring/spring-cloud-azure-integration-tests/**",
Expand Down Expand Up @@ -691,6 +690,14 @@
"kldn",
"dccf"
]
},
{
"filename": "sdk/servicebus/azure-messaging-servicebus/**",
"words": [
"Conniey",
"qpid",
"unretriable"
]
}
],
"allowCompoundWords": true
Expand Down
4 changes: 2 additions & 2 deletions sdk/servicebus/azure-messaging-servicebus/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ Fixed the issue that the second call of `ServiceBusReceiverClient.complete` is s

### Breaking Changes
- Changed `receiveMessages` API to return `ServiceBusReceivedMessage` instead of ServiceBusReceivedMessageContext in
`ServiceBusReceiverAsynClient` and `ServiceBusReceiverClient`.
`ServiceBusReceiverAsyncClient` and `ServiceBusReceiverClient`.
- Removed `SendVia` option from `ServiceBusClientBuilder`. See issue for more detail
[16942](https://github.com/Azure/azure-sdk-for-java/pull/16942).
- Removed `sessionId` setting from `ServiceBusSessionReceiverClientBuilder` as creating receiver clients bound to a
Expand All @@ -339,7 +339,7 @@ Fixed the issue that the second call of `ServiceBusReceiverClient.complete` is s
`ServiceBusSessionProcessorClientBuilder` as the feature of receiving messages from multiple sessions is moved from
the receiver client to the new `ServiceBusSessionProcessorClient`.
- Renamed `tryAdd` to `tryAddMessage` in `ServiceBusMessageBatch`.
- Removed `sessionId` specific methods from `ServiceBusReceiverAsynClient` and `ServiceBusReceiverClient` because now
- Removed `sessionId` specific methods from `ServiceBusReceiverAsyncClient` and `ServiceBusReceiverClient` because now
receiver client is always tied to one session.

### Bug Fixes
Expand Down
4 changes: 2 additions & 2 deletions sdk/servicebus/azure-messaging-servicebus/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ The recommended way to solve the specific exception the AMQP exception represent

### Understanding the APIs behavior

The document [here][sync_receivemessages_implcit_prefetch] provides insights into the expected behavior of synchronous `receiveMessages` API when using it to obtain more than one message (a.k.a. implicit prefetching).
The document [here][sync_receivemessages_implicit_prefetch] provides insights into the expected behavior of synchronous `receiveMessages` API when using it to obtain more than one message (a.k.a. implicit prefetching).

## Next steps

Expand Down Expand Up @@ -475,7 +475,7 @@ Guidelines](https://github.com/Azure/azure-sdk-for-java/blob/main/CONTRIBUTING.m
[topic_concept]: https://docs.microsoft.com/azure/service-bus-messaging/service-bus-messaging-overview#topics
[wiki_identity]: https://github.com/Azure/azure-sdk-for-java/wiki/Identity-and-Authentication
[known-issue-binarydata-notfound]: https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/known-issues.md#can-not-resolve-binarydata-or-noclassdeffounderror-version-700
[sync_receivemessages_implcit_prefetch]: https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/docs/SyncReceiveAndPrefetch.md
[sync_receivemessages_implicit_prefetch]: https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/servicebus/azure-messaging-servicebus/docs/SyncReceiveAndPrefetch.md
[peek_lock_mode_docs]: https://learn.microsoft.com/azure/service-bus-messaging/message-transfers-locks-settlement#peeklock
[receive_and_delete_mode_docs]: https://learn.microsoft.com/azure/service-bus-messaging/message-transfers-locks-settlement#receiveanddelete
![Impressions](https://azure-sdk-impressions.azurewebsites.net/api/impressions/azure-sdk-for-java%2Fsdk%2Fservicebus%2Fazure-messaging-servicebus%2FREADME.png)
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ try {
```

The new Java SDK provides a dedicated processor client to which you can pass your message and error handlers.
Like the older SDK, this supports auto completion of messages and automatica renewal of message/session locks.
Like the older SDK, this supports auto completion of messages and automatically renewal of message/session locks.

For a more fine grained control and advanced features, you still have the `ServiceBusReceiverClient` and it's async
counterpart `ServiceBusReceiverAsyncClient`.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ final class FluxAutoLockRenew extends FluxOperator<ServiceBusMessageContext, Ser
* @throws NullPointerException If {@code onRenewLock}, {@code messageLockContainer},
* {@code ReceiverOptions} or {@code maxAutoLockRenewDuration} is null.
*
* @throws IllegalArgumentException If eceiverOptions.maxLockRenewalDuration is zero or negative.
* @throws IllegalArgumentException If receiverOptions.maxLockRenewalDuration is zero or negative.
*/
FluxAutoLockRenew(
Flux<? extends ServiceBusMessageContext> source, ReceiverOptions receiverOptions,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1308,8 +1308,8 @@ public void close() {
}

try {
// releated with issue https://github.com/Azure/azure-sdk-for-java/issues/25709. When defining ServiceBusProcessorClient as bean in SpringBoot application and throw error in processMessage(), the application can not be shutdown gracefully using ctrl-c.
// The cause is completionLock's acquire stucks. So we add a timeout for acquiring lock here to avoid the stuck.
// Related with issue https://github.com/Azure/azure-sdk-for-java/issues/25709. When defining ServiceBusProcessorClient as bean in SpringBoot application and throw error in processMessage(), the application can not be shutdown gracefully using ctrl-c.
// The cause is completionLock's acquire method is stuck. So we have added a timeout for acquiring the lock, to work around the issue.
boolean acquired = completionLock.tryAcquire(5, TimeUnit.SECONDS);
if (!acquired) {
LOGGER.info("Unable to obtain completion lock.");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -749,7 +749,7 @@ public void commitTransaction(ServiceBusTransactionContext transactionContext) {
*
* @param transactionContext The transaction to be rollback.
*
* @throws IllegalStateException if the receiver is alread disposed.
* @throws IllegalStateException if the receiver is already disposed.
* @throws NullPointerException if {@code transactionContext} or {@code transactionContext.transactionId} is null.
* @throws ServiceBusException if the transaction could not be rolled back.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public interface AuthorizationRule {
/**
* Gets the name of the authorization rule.
*
* @return name of the authoriation rule.
* @return name of the authorization rule.
*/
String getKeyName();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
* match.
* <p>
* This provides an efficient shortcut for declarations of filters that deal only with correlation
* equality. In this case the cost of the lexigraphical analysis of the expression can be avoided. Not only will
* equality. In this case the cost of the lexicographical analysis of the expression can be avoided. Not only will
* correlation filters be optimized at declaration time, but they will also be optimized at runtime. Correlation filter
* matching can be reduced to a hashtable lookup, which aggregates the complexity of the set of defined correlation
* filters to <code>O(1)</code>.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ public RuleProperties getDefaultRule() {
}

/***
* Set the rule that the subscriptions hould be created with, if any.
* Set the rule that the subscriptions should be created with, if any.
*
* @param ruleProperties the rule description (name, action, filter)
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public SqlRuleAction(String sqlExpression) {
}

/**
* Package private constructor for creating a model deserialised from the service.
* Package private constructor for creating a model deserialized from the service.
*
* @param sqlExpression SQL expression for the action.
* @param compatibilityLevel The compatibility level.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public SqlRuleFilter(String sqlExpression) {
}

/**
* Package private constructor for creating a model deserialised from the service.
* Package private constructor for creating a model deserialized from the service.
*
* @param sqlExpression SQL expression for the filter.
* @param compatibilityLevel The compatibility level.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public class DeadletterQueueSample {
new Person("Faraday", "Michael"),
new Person("Galilei", "Galileo"),
new Person("Kepler", "Johannes"),
new Person("Kopernikus", "Nikolaus")
new Person("Copernicus", "Nikola")
);

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,7 @@ public void run() throws InterruptedException {
// Setting the sessionId parameter ensures all messages end up in the same session and are received in order.
List<ServiceBusMessage> messages = Arrays.asList(
new ServiceBusMessage(BinaryData.fromBytes("Hello".getBytes(UTF_8))).setSessionId(sessionId),
new ServiceBusMessage(BinaryData.fromBytes("Bonjour".getBytes(UTF_8))).setSessionId(sessionId),
new ServiceBusMessage(BinaryData.fromBytes("Guten tag".getBytes(UTF_8))).setSessionId(sessionId)
new ServiceBusMessage(BinaryData.fromBytes("Bonjour".getBytes(UTF_8))).setSessionId(sessionId)
);

// This sends all the messages in a single message batch.
Expand Down