HandlingForCancelledExceptions - #31882
Merged
xinlian12 merged 13 commits intoNov 19, 2022
Merged
Conversation
xinlian12
requested review from
FabianMeiswinkel,
aayush3011,
jeet1995,
kirankumarkolli,
kushagraThapar,
milismsft and
simorenoh
as code owners
November 2, 2022 07:03
Collaborator
|
API change check API changes are not detected in this pull request. |
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
6 tasks
kushagraThapar
approved these changes
Nov 17, 2022
kushagraThapar
left a comment
Member
There was a problem hiding this comment.
LGTM, great work @xinlian12 !
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
In our recent CI pipeline, local test & spark jobs, the following exception has been logged. It does not really impact the prod requests, but could cause confusion.
Root cause:
The exception has only started to show up since
4.37.1. Since4.37.1, theazure-coredependency has upgraded from1.32.0 to 1.33.0, which introduced the reactor-core upgrade from3.4.22 to 3.4.23.In reactor-core
3.4.23, the Mono.fromCompletionStage behavior has changed when it is got cancelled because of change in this PR: reactor/reactor-core#3146. Before it will not cancel the future, since3.4.23, it will also cancel the future. Here is a discussion about the behavior change: reactor/reactor-core#3235The reason we are seeing the exception mentioned above is because we subscribed again internally of the cancelled future, which caused the
CancellationExceptionSpark query tests:

Master:
PR:
