Suppress error report for CancellationException - #32175
Merged
FabianMeiswinkel merged 2 commits intoNov 16, 2022
Merged
Conversation
FabianMeiswinkel
requested review from
Pilchie,
aayush3011,
jeet1995,
kirankumarkolli,
kushagraThapar,
milismsft,
simorenoh and
xinlian12
as code owners
November 15, 2022 22:13
Collaborator
|
API change check API changes are not detected in this pull request. |
kushagraThapar
approved these changes
Nov 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recent reactor change resulted in excessive logging of CancellationException that is caused by reactor not cancelling Future from the Mono-wrapper. Annie has a fix candidate for it (see [PR#https://github.com//pull/31882]) - but it is a bigger change - so, we will not merge it into the Nov. release. This is a short-term workaroudn to avoid flooding the logs (esepcially in Spark where Cancellations are happening at the end of each query for a spark partition/epk-range)
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines