Move AzurePasswordlessPropertiesMapping to implementation package#34318
Merged
chenrujun merged 2 commits intoApr 4, 2023
Conversation
ghost
added
the
|
Command 'java' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
Contributor
Author
|
/azp run java - spring |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Contributor
Author
|
/azp run java - spring |
|
Azure Pipelines successfully started running 1 pipeline(s). |
backwind1233
marked this pull request as ready for review
April 4, 2023 06:18
backwind1233
requested review from
Netyyyy,
chenrujun,
fangjian0423,
moarychan,
saragluna,
stliu and
yiliuTo
as code owners
April 4, 2023 06:18
Contributor
Author
|
@chenrujun please help review this package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The enum AzurePasswordlessPropertiesMapping should only be used inside the interface PasswordlessProperties. But if is defined inside PasswordlessProperties, it can only be public.
Goal
Move AzurePasswordlessPropertiesMapping to implementation package.