Skip to content

Address 5.3.0 api review#35631

Merged
saragluna merged 7 commits into
Azure:feature/spring-boot-3from
saragluna:xiada/sb3-jms-passwordless-apireview
Jun 27, 2023
Merged

Address 5.3.0 api review#35631
saragluna merged 7 commits into
Azure:feature/spring-boot-3from
saragluna:xiada/sb3-jms-passwordless-apireview

Conversation

@saragluna

Copy link
Copy Markdown
Member

Description

Address the Spring Cloud Azure 5.3.0 release api review, to port #34267 and #34318 to this branch.

This PR also did some refactor to reduce code duplication.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions Bot added the azure-spring All azure-spring related issues label Jun 27, 2023
@azure-sdk

azure-sdk commented Jun 27, 2023

Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

spring-cloud-azure-core
spring-cloud-azure-service
spring-cloud-azure-autoconfigure

@saragluna

Copy link
Copy Markdown
Member Author

/azp run java - spring - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@saragluna saragluna marked this pull request as ready for review June 27, 2023 06:45

@moarychan moarychan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@saragluna saragluna merged commit afc17b0 into Azure:feature/spring-boot-3 Jun 27, 2023
@saragluna saragluna deleted the xiada/sb3-jms-passwordless-apireview branch June 27, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants