Skip to content

Fix spring tests emulator#35404

Merged
kushagraThapar merged 9 commits into
Azure:mainfrom
kushagraThapar:fix_spring_tests_emulator
Jun 9, 2023
Merged

Fix spring tests emulator#35404
kushagraThapar merged 9 commits into
Azure:mainfrom
kushagraThapar:fix_spring_tests_emulator

Conversation

@kushagraThapar

@kushagraThapar kushagraThapar commented Jun 9, 2023

Copy link
Copy Markdown
Member
  • Fix spring tests emulator

@github-actions github-actions Bot added the azure-spring All azure-spring related issues label Jun 9, 2023
@github-actions github-actions Bot added the Cosmos label Jun 9, 2023
@azure-sdk

azure-sdk commented Jun 9, 2023

Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

xinlian12
xinlian12 reviewed Jun 9, 2023
View reviewed changes
Comment thread sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/CosmosItemTest.java
validateItemResponse(properties, itemResponse);

properties = getDocumentDefinition(UUID.randomUUID().toString());
logger.info("Testing log");

@xinlian12 xinlian12 Jun 9, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep or remove?

xinlian12
xinlian12 reviewed Jun 9, 2023
View reviewed changes
Comment thread ...ure-spring-data-cosmos/src/test/java/com/azure/spring/data/cosmos/core/CosmosTemplateIT.java
assertNotNull(throughput);
assertEquals(Integer.parseInt(TestConstants.AUTOSCALE_MAX_THROUGHPUT),
throughput.getProperties().getAutoscaleMaxThroughput());
collectionManager.deleteContainer(autoScaleSampleInfo);

@xinlian12 xinlian12 Jun 9, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be in a try finally block - just in case somehow we got some failures

xinlian12
xinlian12 reviewed Jun 9, 2023
View reviewed changes
Comment thread ...ring/azure-spring-data-cosmos/src/test/java/com/azure/spring/data/cosmos/domain/Address.java
import java.util.Objects;

@Container()
@Container(ru = TestConstants.DEFAULT_MINIMUM_RU)

@xinlian12 xinlian12 Jun 9, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we will have to specifically configure the RU here (default is 400 I think )

xinlian12
xinlian12 approved these changes Jun 9, 2023
View reviewed changes

@xinlian12 xinlian12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

trande4884
trande4884 reviewed Jun 9, 2023
View reviewed changes
Comment thread ...ring/azure-spring-data-cosmos/src/test/java/com/azure/spring/data/cosmos/domain/Address.java
import java.util.Objects;

@Container()
@Container(ru = TestConstants.DEFAULT_MINIMUM_RU)

@trande4884 trande4884 Jun 9, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be needed, the default is already 400 ru's isn't it?

trande4884
trande4884 reviewed Jun 9, 2023
View reviewed changes
Comment thread ...ring/azure-spring-data-cosmos/src/test/java/com/azure/spring/data/cosmos/domain/Address.java
import java.util.Objects;

@Container()
@Container(ru = TestConstants.DEFAULT_MINIMUM_RU)

@trande4884 trande4884 Jun 9, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be needed, the default is already 400 ru's isn't it?

trande4884
trande4884 reviewed Jun 9, 2023
View reviewed changes
Comment thread ...ring/azure-spring-data-cosmos/src/test/java/com/azure/spring/data/cosmos/domain/Address.java
import java.util.Objects;

@Container()
@Container(ru = TestConstants.DEFAULT_MINIMUM_RU)

@trande4884 trande4884 Jun 9, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be needed, the default is already 400 ru's isn't it?

@kushagraThapar kushagraThapar merged commit ef4a1fd into Azure:main Jun 9, 2023
trande4884 pushed a commit that referenced this pull request Jun 12, 2023
@kushagraThapar @trande4884
Fix spring tests emulator (#35404)
77f35cb 
* Updated release versions to 4.46.0 for azure-cosmos and 4.19.0 for spark connector

* Updated spark readme files

* Updated quick start files

* Fixed spring tests for emulator

* Fix imports

* Added a dummy commit to run Java cosmos CI
trande4884 pushed a commit that referenced this pull request Jun 13, 2023
@kushagraThapar @trande4884
Fix spring tests emulator (#35404)
1638bc7 
* Updated release versions to 4.46.0 for azure-cosmos and 4.19.0 for spark connector

* Updated spark readme files

* Updated quick start files

* Fixed spring tests for emulator

* Fix imports

* Added a dummy commit to run Java cosmos CI
trande4884 pushed a commit that referenced this pull request Jun 20, 2023
@kushagraThapar @trande4884
Fix spring tests emulator (#35404)
0205197 
* Updated release versions to 4.46.0 for azure-cosmos and 4.19.0 for spark connector

* Updated spark readme files

* Updated quick start files

* Fixed spring tests for emulator

* Fix imports

* Added a dummy commit to run Java cosmos CI
trande4884 added a commit that referenced this pull request Jun 21, 2023
@trande4884 @kushagraThapar @saragluna
Feature/spring boot 3 pr35404, 35453 and 35485 (#35482)
f50453d 
* Updated spring CI (#35453)

* Updated spring CI

* Update ci.yml

Attempting to fix CI run with stages.

* Update ci.yml

Attempting to fix CI issues.

* Update ci.yml

Reverting attempt.

* Update ci.yml

Reverting changes to spring/si.yml

* Update ci.yml

Reverting syntax.

* Create ci.cosmos.yml

Adding new yaml for cosmos emulator.

* Update ci.cosmos.yml

Removing un-needed code.

* Update ci.cosmos.yml

Adding artifacts.

* Update ci.cosmos.yml

Working on getting the new pipeline running.

* Update ci.cosmos.yml

Small change to restart pipeline

* Update ci.cosmos.yml

Fixing syntax.

* Update ci.cosmos.yml

Removing artifact.

* Update ci.cosmos.yml

Adding filter to only run spring tests.

* Update ci.cosmos.yml

Fixing syntax.

* Update ci.cosmos.yml

Fixing matrix filter.

* Update ci.cosmos.yml

Working on matrix filter.

* Update ci.cosmos.yml

Working on matrix filters.

* Updating ci logic.

Working on fixing MatrixFilters.

* Update cosmos-sdk-client.yml

Fixing matrix filter.

* Update ci.cosmos.yml

Fixing CI issue.

* Update ci.cosmos.yml

Changing to only run for azure-spring-data-cosmos

---------

Co-authored-by: Trevor Anderson <63077034+trande4884@users.noreply.github.com>
Co-authored-by: Trevor Anderson <trande@microsoft.com>

* Update ci.cosmos.yml

Adding Java Version Matrix Filter.

* Update cosmos-sdk-client.yml

Fixing java 1.8 and 1.11 issues.

* Spring ci fixing matrix filter (#35485)

* Merging

* Updating yaml filters to have a new param to support dynamic filtering in SB3.

* Fix spring tests emulator (#35404)

* Updated release versions to 4.46.0 for azure-cosmos and 4.19.0 for spark connector

* Updated spark readme files

* Updated quick start files

* Fixed spring tests for emulator

* Fix imports

* Added a dummy commit to run Java cosmos CI

* change to log4j-slf4j2-impl to run the ci pipelines

---------

Co-authored-by: Kushagra Thapar <kuthapar@microsoft.com>
Co-authored-by: Xiaolu Dai <xiada@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trande4884 trande4884 trande4884 left review comments
@xinlian12 xinlian12 xinlian12 approved these changes
@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft
@samvaity samvaity Awaiting requested review from samvaity
@g2vinay g2vinay Awaiting requested review from g2vinay
@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio
@srnagar srnagar Awaiting requested review from srnagar
@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles
@backwind1233 backwind1233 Awaiting requested review from backwind1233
@chenrujun chenrujun Awaiting requested review from chenrujun
@hui1110 hui1110 Awaiting requested review from hui1110
@Netyyyy Netyyyy Awaiting requested review from Netyyyy
@saragluna saragluna Awaiting requested review from saragluna saragluna is a code owner
@stliu stliu Awaiting requested review from stliu
@yiliuTo yiliuTo Awaiting requested review from yiliuTo
@moarychan moarychan Awaiting requested review from moarychan moarychan is a code owner
@fangjian0423 fangjian0423 Awaiting requested review from fangjian0423
@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel
@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner
@milismsft milismsft Awaiting requested review from milismsft
@aayush3011 aayush3011 Awaiting requested review from aayush3011
@simorenoh simorenoh Awaiting requested review from simorenoh
@jeet1995 jeet1995 Awaiting requested review from jeet1995
@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees

No one assigned

Labels

azure-spring All azure-spring related issues Cosmos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kushagraThapar @azure-sdk @trande4884 @xinlian12