-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix spring tests emulator #35404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spring tests emulator #35404
Changes from all commits
b38fc9e
4be0d29
12d631e
1a92e79
2b06c79
40b7970
f056783
f2beedd
acddc0e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -967,6 +967,7 @@ public void createWithAutoscale() throws ClassNotFoundException { | |
| assertNotNull(throughput); | ||
| assertEquals(Integer.parseInt(TestConstants.AUTOSCALE_MAX_THROUGHPUT), | ||
| throughput.getProperties().getAutoscaleMaxThroughput()); | ||
| collectionManager.deleteContainer(autoScaleSampleInfo); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should this be in a try finally block - just in case somehow we got some failures |
||
| } | ||
|
|
||
| @Test | ||
|
|
@@ -987,6 +988,7 @@ public void createDatabaseWithThroughput() throws ClassNotFoundException { | |
| final CosmosAsyncDatabase database = client.getDatabase(configuredThroughputDbName); | ||
| final ThroughputResponse response = database.readThroughput().block(); | ||
| assertEquals(expectedRequestUnits, response.getProperties().getManualThroughput()); | ||
| deleteDatabaseIfExists(configuredThroughputDbName); | ||
| } | ||
|
|
||
| @Test | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ | |
|
|
||
| import java.util.Objects; | ||
|
|
||
| @Container() | ||
| @Container(ru = TestConstants.DEFAULT_MINIMUM_RU) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why we will have to specifically configure the RU here (default is 400 I think )
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this should be needed, the default is already 400 ru's isn't it?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this should be needed, the default is already 400 ru's isn't it?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this should be needed, the default is already 400 ru's isn't it? |
||
| public class Address { | ||
|
|
||
| public static final Address TEST_ADDRESS1_PARTITION1 = new Address( | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep or remove?