Update aad default configuration condition#36124
Merged
Merged
Conversation
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
moarychan
marked this pull request as ready for review
July 27, 2023 05:58
moarychan
requested review from
Netyyyy,
backwind1233,
chenrujun,
fangjian0423,
hui1110,
saragluna,
stliu and
yiliuTo
as code owners
July 27, 2023 05:58
6 tasks
saragluna
requested changes
Jul 27, 2023
|
|
||
| #### Bugs Fixed | ||
| - Fix the issue that `AzureMessagingListenerAutoConfiguration` not included in spring.factories [#34690](https://github.com/Azure/azure-sdk-for-java/issues/34690), [#35716](https://github.com/Azure/azure-sdk-for-java/pull/35716). | ||
| - Fix AAD default configuration condition is not perfect [#36124](https://github.com/Azure/azure-sdk-for-java/pull/36124). |
Member
There was a problem hiding this comment.
Can we be more specific with this changelog description.
| import static com.azure.spring.cloud.autoconfigure.aad.implementation.WebApplicationContextRunnerUtils.resourceServerRunner; | ||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| public class AadResourceServerConfigurationTests { |
| import static com.azure.spring.cloud.autoconfigure.aad.implementation.WebApplicationContextRunnerUtils.webApplicationContextRunner; | ||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| public class AadWebApplicationConfigurationTests { |
saragluna
approved these changes
Jul 27, 2023
moarychan
enabled auto-merge (squash)
July 27, 2023 08:27
moarychan
disabled auto-merge
July 27, 2023 08:51
Contributor
|
/check-enforcer override |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since there are two ways to configure Spring Security filters, the default configuration does not consider the custom bean
SecurityFilterChain.azure-sdk-for-java/sdk/spring/spring-cloud-azure-autoconfigure/src/main/java/com/azure/spring/cloud/autoconfigure/aad/configuration/AadWebApplicationConfiguration.java
Line 60 in 2fca963
See more from customer report: #32279 (comment)
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines