Skip to content

Improve AAD default configuration condition for Spring Boot 3 branch#36126

Merged
Netyyyy merged 5 commits into
Azure:feature/spring-boot-3from
moarychan:moary/fix-aad-condition-sb3
Jul 28, 2023
Merged

Improve AAD default configuration condition for Spring Boot 3 branch#36126
Netyyyy merged 5 commits into
Azure:feature/spring-boot-3from
moarychan:moary/fix-aad-condition-sb3

Conversation

@moarychan

@moarychan moarychan commented Jul 27, 2023

Copy link
Copy Markdown
Member

Description

Since there are two ways to configure Spring Security filters for SB2, the default configuration does not consider the custom bean SecurityFilterChain.

Sync using annotation @ConditionalOnDefaultWebSecurity for SB3, refer: #36124

See more from customer report: #32279 (comment)

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@saragluna saragluna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants