Bugfix - Allow configuration of disableChallengeResourceVerification property of AKV SecretClient by nagyesta · Pull Request #36603 · Azure/azure-sdk-for-java

nagyesta · 2023-08-30T22:19:18Z

Description

Fixes #36561

Adds challengeResourceVerificationEnabled property to properties objects
Includes new property in mapping methods
Configures SecretClient in Factory when challengeResourceVerificationEnabled is set
Configures CertificateClient in Factory when challengeResourceVerificationEnabled is set
Updates/adds new tests
Updates Changelog

All SDK Contribution checklist:

The pull request does not introduce [breaking changes]
CHANGELOG is updated for new features, bug fixes or other significant changes.
I have read the contribution guidelines.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

* Update versions manually * Update version/changelog/readme

* Increment package versions for spring releases * Update pom.xml * Update version_client.txt --------- Co-authored-by: Muyao Feng <92105726+Netyyyy@users.noreply.github.com>

- Adds disableChallengeResourceVerification property to properties objects - Includes new property in mapping methods - Configures SecretClient in Factory when disableChallengeResourceVerification is set - Configures CertificateClient in Factory when disableChallengeResourceVerification is set - Updates/adds new tests - Updates Changelog Resolves Azure#36561 Signed-off-by: Esta Nagy <nagyesta@gmail.com>

github-actions · 2023-08-30T22:19:44Z

Thank you for your contribution @nagyesta! We will review the pull request and get back to you soon.

nagyesta · 2023-08-30T22:20:14Z

@microsoft-github-policy-service agree

saragluna · 2023-08-31T01:19:53Z

@nagyesta thanks for the PR, this PR looks great, I left some comments to your PR, please check.

… - Code review fixes #1 - Renames disableChallengeResourceVerification to challengeResourceVerificationEnabled - Adds additional JavaDoc Resolves Azure#36561 Signed-off-by: Esta Nagy <nagyesta@gmail.com>

nagyesta · 2023-08-31T18:15:05Z

Hi @saragluna ,
I have completed the requested changes, please let me know in case anything else is needed.
Thank you!

- Fix a missed JavaDoc Signed-off-by: Esta Nagy <nagyesta@gmail.com>

…nge-resource-verification-akv-_on_5-5-0

saragluna · 2023-09-01T07:44:00Z

@nagyesta I changed the base branch to feature/spring-boot-3, which is our base branch for Spring Boot 3 development.

…onal-spring-configuration-metadata.json

saragluna · 2023-09-01T08:05:58Z

@nagyesta I pushed one commit to your PR, the changes including:

Refine the javadoc description, according to the Spring Boot doc: https://docs.spring.io/spring-boot/docs/current/reference/html/features.html#features.developing-auto-configuration.custom-starter.configuration-keys (check the "Here are some rules we follow internally to make sure descriptions are consistent:" part)
Add one missing configuration metadata in the additional-spring-configuration-metadata.json file. You could build the project locally, and a file target/classes/META-INF/spring-configuration-metadata.json will be generated under the autoconfigure module. This entry is missing because the Spring Boot annotation processor can't handle the nested collection objects correctly.

saragluna · 2023-09-01T08:24:21Z

@nagyesta I left two more comments.

… - Code review fixes Azure#3 - Simplifies factory method logic as per code review recommendation Resolves Azure#36561 Signed-off-by: Esta Nagy <nagyesta@gmail.com>

nagyesta · 2023-09-01T18:23:39Z

Hi @saragluna ,
thank you for making the changes you have mentioned! I have updated the branch with the requested simplifications in the factory calls. Please let me know in case further changes are required!

Regarding the base branch, I wasn't aware of it sorry! Will it be a problem that the PR now contains the version bump specific changes from the release branch?

saragluna · 2023-09-02T00:49:58Z

Thanks @nagyesta, no worries, the version bump is already in the base branch, so it won't be an issue.

saragluna · 2023-09-02T00:51:26Z

@Netyyyy, let's cherry pick this feature to the main branch.

Netyyyy and others added 3 commits August 25, 2023 16:29

Prepare for Spring Cloud Azure 5.5.0 release (Azure#36517)

c7aef8b

* Update versions manually * Update version/changelog/readme

Increment versions for spring releases (Azure#36547)

61f2cf4

* Increment package versions for spring releases * Update pom.xml * Update version_client.txt --------- Co-authored-by: Muyao Feng <92105726+Netyyyy@users.noreply.github.com>

nagyesta requested review from Netyyyy, backwind1233, chenrujun, fangjian0423, hui1110, moarychan, saragluna, stliu and yiliuTo as code owners August 30, 2023 22:19

github-actions Bot added azure-spring All azure-spring related issues Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Aug 30, 2023

nagyesta mentioned this pull request Aug 30, 2023

[BUG] The Spring Key Vault integration (spring-cloud-azure-starter-keyvault-secrets) does not work with local test doubles #36561

Closed

3 tasks

saragluna requested changes Aug 31, 2023

View reviewed changes

Comment thread ...azure/spring/cloud/autoconfigure/implementation/keyvault/common/AzureKeyVaultProperties.java Outdated

Allows configuration of disableChallengeResourceVerification property…

dc3dd89

… - Code review fixes #1 - Renames disableChallengeResourceVerification to challengeResourceVerificationEnabled - Adds additional JavaDoc Resolves Azure#36561 Signed-off-by: Esta Nagy <nagyesta@gmail.com>

nagyesta commented Aug 31, 2023

View reviewed changes

Comment thread ...figure/implementation/keyvault/secrets/properties/AzureKeyVaultPropertySourceProperties.java Outdated

Allows configuration of disableChallengeResourceVerification property

01ba579

- Fix a missed JavaDoc Signed-off-by: Esta Nagy <nagyesta@gmail.com>

saragluna changed the base branch from release/spring-cloud-azure_5.5.0 to feature/spring-boot-3 September 1, 2023 07:36

saragluna requested review from FabianMeiswinkel, aayush3011, kushagraThapar, simorenoh and xinlian12 as code owners September 1, 2023 07:36

saragluna requested review from Pilchie, jeet1995 and mrm9084 as code owners September 1, 2023 07:36

Merge branch 'feature/spring-boot-3' into bugfix/36561-disable-challe…

4872bb2

…nge-resource-verification-akv-_on_5-5-0

Improve the configuration properties javadoc, and complete the additi…

48bd6bd

…onal-spring-configuration-metadata.json

saragluna requested changes Sep 1, 2023

View reviewed changes

Comment thread ...ring/cloud/service/implementation/keyvault/certificates/CertificateClientBuilderFactory.java Outdated

Comment thread ...m/azure/spring/cloud/service/implementation/keyvault/secrets/SecretClientBuilderFactory.java Outdated

Allows configuration of disableChallengeResourceVerification property…

79d9606

… - Code review fixes Azure#3 - Simplifies factory method logic as per code review recommendation Resolves Azure#36561 Signed-off-by: Esta Nagy <nagyesta@gmail.com>

saragluna approved these changes Sep 2, 2023

View reviewed changes

saragluna merged commit a0d30ff into Azure:feature/spring-boot-3 Sep 2, 2023

Netyyyy mentioned this pull request Sep 4, 2023

Allow configuration of disableChallengeResourceVerification property of AKV SecretClient #36628

Merged

6 tasks

nagyesta deleted the bugfix/36561-disable-challenge-resource-verification-akv-_on_5-5-0 branch September 5, 2023 05:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bugfix - Allow configuration of disableChallengeResourceVerification property of AKV SecretClient#36603

Bugfix - Allow configuration of disableChallengeResourceVerification property of AKV SecretClient#36603
saragluna merged 8 commits into
Azure:feature/spring-boot-3from
nagyesta:bugfix/36561-disable-challenge-resource-verification-akv-_on_5-5-0

nagyesta commented Aug 30, 2023 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 30, 2023

Uh oh!

nagyesta commented Aug 30, 2023

Uh oh!

Uh oh!

saragluna commented Aug 31, 2023

Uh oh!

nagyesta commented Aug 31, 2023

Uh oh!

Uh oh!

saragluna commented Sep 1, 2023

Uh oh!

saragluna commented Sep 1, 2023

Uh oh!

Uh oh!

Uh oh!

saragluna commented Sep 1, 2023

Uh oh!

nagyesta commented Sep 1, 2023

Uh oh!

saragluna commented Sep 2, 2023

Uh oh!

saragluna commented Sep 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

nagyesta commented Aug 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

All SDK Contribution checklist:

General Guidelines and Best Practices

Testing Guidelines

Uh oh!

github-actions Bot commented Aug 30, 2023

Uh oh!

nagyesta commented Aug 30, 2023

Uh oh!

Uh oh!

saragluna commented Aug 31, 2023

Uh oh!

nagyesta commented Aug 31, 2023

Uh oh!

Uh oh!

saragluna commented Sep 1, 2023

Uh oh!

saragluna commented Sep 1, 2023

Uh oh!

Uh oh!

Uh oh!

saragluna commented Sep 1, 2023

Uh oh!

nagyesta commented Sep 1, 2023

Uh oh!

saragluna commented Sep 2, 2023

Uh oh!

saragluna commented Sep 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nagyesta commented Aug 30, 2023 •

edited

Loading