azure-storage-blob BlobClient.upload_blob mistyped argument

[jayqi]

• Package Name: azure-storage-blob
• Package Version: 12.9.0

Describe the bug

azure.storage.blob.BlobClient.upload_blob and the method that it wraps BlobClient._upload_blob_options both have the type annotation Union[Iterable[AnyStr], IO[AnyStr]] for the data argument.

azure-sdk-for-python/sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py

Lines 573 to 579 in d720e56

	def upload_blob( # pylint: disable=too-many-locals
	self, data, # type: Union[Iterable[AnyStr], IO[AnyStr]]
	blob_type=BlobType.BlockBlob, # type: Union[str, BlobType]
	length=None, # type: Optional[int]
	metadata=None, # type: Optional[Dict[str, str]]
	**kwargs
	):

azure-sdk-for-python/sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py

Lines 339 to 345 in d720e56

	def _upload_blob_options( # pylint:disable=too-many-statements
	self, data, # type: Union[Iterable[AnyStr], IO[AnyStr]]
	blob_type=BlobType.BlockBlob, # type: Union[str, BlobType]
	length=None, # type: Optional[int]
	metadata=None, # type: Optional[Dict[str, str]]
	**kwargs
	):

However, these methods also support cases where data is str or bytes.

This bit handles the case where data is str:

azure-sdk-for-python/sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py

Lines 361 to 362 in d720e56

	if isinstance(data, six.text_type):
	data = data.encode(encoding) # type: ignore

and this bit handles the case where data is bytes:

azure-sdk-for-python/sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py

Lines 368 to 369 in d720e56

	if isinstance(data, bytes):
	stream = BytesIO(data)

Expected behavior

The current annotation should be Union[AnyStr, Iterable[AnyStr], IO[AnyStr]].

[amishra-dev]

@iscai-msft / @jalauzon-msft is this issue fixed or still needs a fix from us?