Skip to content

Fix type annotation for azure-storage-blob BlobClient.upload_blob - #23363

Merged
jalauzon-msft merged 2 commits into
Azure:mainfrom
jayqi:jyq-upload-blob-typing
Mar 9, 2022
Merged

Fix type annotation for azure-storage-blob BlobClient.upload_blob#23363
jalauzon-msft merged 2 commits into
Azure:mainfrom
jayqi:jyq-upload-blob-typing

Conversation

@jayqi

@jayqi jayqi commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

Description

This PR adds a missing AnyStr type annotation to the data argument of BlobClient.upload_blob of azure-storage-blob.

Fixes #23362.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [] Pull request includes test coverage for the included changes.

@ghost ghost added Storage Storage Service (Queues, Blobs, Files) customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Mar 7, 2022
@ghost

ghost commented Mar 7, 2022

Copy link
Copy Markdown

Thank you for your contribution jayqi! We will review the pull request and get back to you soon.

@check-enforcer

check-enforcer Bot commented Mar 7, 2022

Copy link
Copy Markdown

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@lmazuel

lmazuel commented Mar 7, 2022

Copy link
Copy Markdown
Member

Hi @jayqi , thanks for the contribution! Would you mind fixing type the async version at the same time?

self, data, # type: Union[Iterable[AnyStr], IO[AnyStr]]

Thanks!

cc @kristapratico @jalauzon-msft

@ghost

ghost commented Mar 9, 2022

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@jayqi

jayqi commented Mar 9, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing @lmazuel, I've made the requested change. (cc @amishra-dev, @jalauzon-msft)

@jalauzon-msft
jalauzon-msft merged commit 06d9e7d into Azure:main Mar 9, 2022
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 7, 2022
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Apr 4, 2023
Change the default response schema to match actual behavior (Azure#23363)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization. Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

azure-storage-blob BlobClient.upload_blob mistyped argument

4 participants