Run identity test using MSAL dev version - #12424
Closed
praveenkuttappan wants to merge 2 commits into
Closed
Conversation
praveenkuttappan
requested review from
danieljurek,
mitchdenny,
scbedd and
weshaggard
as code owners
July 7, 2020 23:16
Member
|
Is this an alternative solution to #12247? |
weshaggard
reviewed
Jul 8, 2020
Member
There was a problem hiding this comment.
Lets avoid duplicating this default matrix. Instead we should allow for adding additional test matrix entries.
Member
Author
There was a problem hiding this comment.
Sure @weshaggard . I will check it again and make required changes.
praveenkuttappan
marked this pull request as draft
July 15, 2020 00:19
praveenkuttappan
force-pushed
the
integrate_msal_dev_test
branch
from
July 15, 2020 07:54
4746587 to
31e34ba
Compare
praveenkuttappan
marked this pull request as ready for review
July 15, 2020 07:55
praveenkuttappan
force-pushed
the
integrate_msal_dev_test
branch
from
August 3, 2020 22:52
31e34ba to
5cac188
Compare
praveenkuttappan
marked this pull request as draft
August 3, 2020 22:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of running identity test using dev version of msal, run it as additional test in test matrix.