Skip to content

Run identity test using MSAL dev version #12424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
praveenkuttappan wants to merge 2 commits into from
Closed

Run identity test using MSAL dev version #12424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a08fcf7
parent 2a96722d0a087ce35f11e72d8928d2c3fa128f74
praveenkuttappan Jul 7, 2020
5cac188
Review changes to remove duplicate test matrix
praveenkuttappan Aug 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion eng/pipelines/templates/jobs/archetype-sdk-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ parameters:
PythonVersion: 'pypy3'
CoverageArg: '--disablecov'
RunForPR: false
AdditionalTestMatrix: []


jobs:
Expand Down Expand Up @@ -97,10 +98,18 @@ jobs:
${{ if ne(parameters.SkipPythonVersion, matrixEntry.value.PythonVersion) }}:
${{ matrixEntry.key }}:
${{ insert }}: ${{ matrixEntry.value }}

${{ each matrixEntry in parameters.AdditionalTestMatrix }}:
${{ matrixEntry.key }}:
${{ insert }}: ${{ matrixEntry.value }}


pool:
vmImage: '$(OSVmImage)'

variables:
InjectedPackages: ${{ parameters.InjectedPackages }}

steps:
- pwsh: |
$toxenvvar = "whl,sdist"
Expand All @@ -125,7 +134,7 @@ jobs:
BuildTargetingString: ${{ parameters.BuildTargetingString }}
ToxTestEnv: $(toxenv)
ToxEnvParallel: ${{ parameters.ToxEnvParallel }}
InjectedPackages: ${{ parameters.InjectedPackages }}
InjectedPackages: $(InjectedPackages)
BeforeTestSteps:
- task: DownloadPipelineArtifact@0
inputs:
Expand Down
4 changes: 4 additions & 0 deletions eng/pipelines/templates/stages/archetype-sdk-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ parameters:
- name: SkipPythonVersion
type: string
default: ''
- name: AdditionalTestMatrix
type: object
default: []

stages:
- stage: Build
Expand All @@ -34,6 +37,7 @@ stages:
BuildDocs: ${{parameters.BuildDocs}}
InjectedPackages: ${{parameters.InjectedPackages}}
SkipPythonVersion: ${{parameters.SkipPythonVersion}}
AdditionalTestMatrix: ${{parameters.AdditionalTestMatrix}}

# The Prerelease and Release stages are conditioned on whether we are building a pull request and the branch.
- ${{if and(ne(variables['Build.Reason'], 'PullRequest'), eq(variables['System.TeamProject'], 'internal'))}}:
Expand Down
10 changes: 10 additions & 0 deletions sdk/identity/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,16 @@ extends:
template: ../../eng/pipelines/templates/stages/archetype-sdk-client.yml
parameters:
ServiceDirectory: identity
AdditionalTestMatrix:
${{ if eq(variables['Build.Reason'],'Schedule') }}:
# If the build is a nightly build also inject msal dev packages
Linux_Python35_msal:
OSVmImage: 'ubuntu-18.04'
PythonVersion: '3.5'
CoverageArg: ''
RunForPR: false
InjectedPackages: 'git+https://github.com/AzureAD/microsoft-authentication-library-for-python@dev'

Artifacts:
- name: azure_identity
safeName: azureidentity