Skip to content

[Blob] Added upload blob from url feature - #15027

Merged
Tamer (tasherif-msft) merged 29 commits into
Azure:feature/storage-stg75from
tasherif-msft:upload-blob-from-url
Dec 2, 2020
Merged

[Blob] Added upload blob from url feature#15027
Tamer (tasherif-msft) merged 29 commits into
Azure:feature/storage-stg75from
tasherif-msft:upload-blob-from-url

Conversation

@tasherif-msft

Copy link
Copy Markdown
Contributor

No description provided.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Nov 5, 2020
@tasherif-msft Tamer (tasherif-msft) changed the title [Blob] Added upload blob from url feature [Blob][WIP] Added upload blob from url feature Nov 5, 2020
@tasherif-msft Tamer (tasherif-msft) changed the title [Blob][WIP] Added upload blob from url feature [Blob][Work in Progress] Added upload blob from url feature Nov 5, 2020
@tasherif-msft Tamer (tasherif-msft) added the feature-request This issue requires a new behavior in the product in order be resolved. label Nov 5, 2020
@tasherif-msft Tamer (tasherif-msft) changed the title [Blob][Work in Progress] Added upload blob from url feature [WIP][Blob] Added upload blob from url feature Nov 6, 2020
@tasherif-msft Tamer (tasherif-msft) changed the title [WIP][Blob] Added upload blob from url feature [Blob] Added upload blob from url feature Nov 11, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

Comment thread sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py Outdated
Comment on lines +505 to +521
:keyword ~datetime.datetime if_modified_since:
A DateTime value. Azure expects the date value passed in to be UTC.
If timezone is included, any non-UTC datetimes will be converted to UTC.
If a date is passed in without timezone info, it is assumed to be UTC.
Specify this header to perform the operation only
if the resource has been modified since the specified time.
:keyword ~datetime.datetime if_unmodified_since:
A DateTime value. Azure expects the date value passed in to be UTC.
If timezone is included, any non-UTC datetimes will be converted to UTC.
If a date is passed in without timezone info, it is assumed to be UTC.
Specify this header to perform the operation only if
the resource has not been modified since the specified date/time.
:keyword str etag:
The destination ETag value, or the wildcard character (*). Used to check if the resource has changed,
and act according to the condition specified by the `match_condition` parameter.
:keyword ~azure.core.MatchConditions match_condition:
The destination match condition to use upon the etag.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we prefix them with "destination_" ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears we're using match_condition keyword for start_copy_blob_from_url(). Should we keep this naming consistent or change it?

Comment thread sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py Outdated
Comment thread sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py Outdated
Comment thread sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py Outdated
Comment thread sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py Outdated
Comment thread sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py Outdated
Comment thread sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py Outdated
Comment thread sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py Outdated
Comment thread sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py Outdated
@tasherif-msft
Tamer (tasherif-msft) merged commit 79c75c8 into Azure:feature/storage-stg75 Dec 2, 2020
Tamer (tasherif-msft) added a commit that referenced this pull request Dec 3, 2020
* [Blob]Generate STG75 Blob Tags (#14986)

* [Blob]Generate STG75 Blob Tags

* update api version

* generator problem

* Fixed tags value

* Removed tag value altogether

Co-authored-by: tasherif-msft <69483382+tasherif-msft@users.noreply.github.com>

* [Storage][STG75]Lease on Get/Set Tags & Find Blob by Tags (#15090)

* [Storage][STG75]Lease on Get/Set Tags & Find Blob by Tags

* pylint

* [Fileshare] Share enable protocol share squash root (#15048)

* generated root squash swagger

* added api version

* added new params

* fixed valueerror

* rerecorded

* docstring fix

* fixed docstrings

* added sync tests

* added async tests

* fixed docstrings

* renamed params and class

* renamed params

* renamed enabled protocols to protocols

* fixed tests

* fixed the validation issue

* changed models to support list[str]

* added tests

* changed models type

* [Blob] Added upload blob from url feature (#15027)

* fixed swagger and added put blob

* added method signitures

* added str

* added more kwargs docstrings

* finished adding kwargs

* return type

* implemented new api

* BlockBlob client fix

* renamed param

* renamed param

* added content length

* test experiment

* added tests sync

* added all tests

* attempting to fix ci

* added if tags match cond keyword

* added more tests

* added extra header

* added more tests and removed keywords

* recorded sync tests

* added async tests

* fixed import issue

* rerecorded test

* changed docstring

* added overwrite and tests

* rerecorded

* cleaned up options method

* cleaned up options method some more

* fixed merge conflict

* marked playback only for fileshares

Co-authored-by: Xiaoxi Fu <49707495+xiafu-msft@users.noreply.github.com>
openapi-sdkautomation Bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Jul 15, 2021
Removed unused definition of ResourceIdentityWithUserAssignedIdentities  (Azure#15027)

* Removed unused definition of ResourceIdentityWithUserAssignedIdentities in servers.json and ManagedInstances.json

* Added "SystemAssigned,UserAssigned" identity type
Cassius Smith (RAY-316) added a commit that referenced this pull request Jul 15, 2021
* CodeGen from PR 15027 in Azure/azure-rest-api-specs
Removed unused definition of ResourceIdentityWithUserAssignedIdentities  (#15027)

* Removed unused definition of ResourceIdentityWithUserAssignedIdentities in servers.json and ManagedInstances.json

* Added "SystemAssigned,UserAssigned" identity type

* version,CHANGELOG

* Update CHANGELOG.md

* Update _version.py

* Update CHANGELOG.md

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zed Lei <59104634+RAY-316@users.noreply.github.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-request This issue requires a new behavior in the product in order be resolved. Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants