[Fileshare] Share enable protocol share squash root - #15048
Merged
Tamer (tasherif-msft) merged 19 commits intoDec 1, 2020
Merged
[Fileshare] Share enable protocol share squash root#15048Tamer (tasherif-msft) merged 19 commits into
Tamer (tasherif-msft) merged 19 commits into
Conversation
ghost
added
the
Tamer (tasherif-msft)
changed the title
Tamer (tasherif-msft)
requested review from
KieranBrantnerMagee,
Charles Lowell (chlowell),
Daniel Jurek (danieljurek),
Krista Pratico (kristapratico),
Laia Patiño (laiapat),
Mitch Denny (mitchdenny),
Scott Beddall (scbedd),
Scott Schaab (schaabs),
Sean Kane (seankane-msft),
Wes Haggard (weshaggard),
Xiang Yan (xiangyan99) and
Adam Ling (yunhaoling)
as code owners
November 6, 2020 22:34
Tamer (tasherif-msft)
changed the title
Tamer (tasherif-msft)
added
the
feature-request
| This is a service returned value, and the value will be set when list shared including deleted ones. | ||
| :ivar ~azure.storage.fileshare.models.ShareRootSquash or str root_squash: | ||
| Possible values include: 'NoRootSquash', 'RootSquash', 'AllSquash'. | ||
| :ivar ~azure.storage.fileshare.models.ShareProtocols or str protocols: |
Contributor
There was a problem hiding this comment.
type should be a list
| The timeout parameter is expressed in seconds. | ||
| :keyword protocols: | ||
| Protocols to enable on the share. Only one protocol can be enabled on the share. | ||
| :paramtype protocols: str or ~azure.storage.fileshare.ShareProtocols |
Contributor
There was a problem hiding this comment.
type should be a list?
Contributor
Author
There was a problem hiding this comment.
No it shouldn't, as discussed with Anna Tisch (@annatisch), we will opt for using a string since users are allowed to use only one protocol at the moment. It doesn't make sense to have them pass ['SMB'] or ['NFS']. As Anna recommended we will stick to string for now and then in the future we can simply change the type to Union[str, [protocols]]. However, it is important to note that we are in fact deserializing the enabled protocols on a share into a list of protocol(s)/str, i.e in ShareProperties (as discussed in the archboard meeting)
Contributor
There was a problem hiding this comment.
as long as you have a plan to make it a list in the future I'm good with it!
Xiaoxi Fu (xiafu-msft)
approved these changes
Dec 1, 2020
Tamer (tasherif-msft)
added a commit
that referenced
this pull request
Dec 3, 2020
* [Blob]Generate STG75 Blob Tags (#14986) * [Blob]Generate STG75 Blob Tags * update api version * generator problem * Fixed tags value * Removed tag value altogether Co-authored-by: tasherif-msft <69483382+tasherif-msft@users.noreply.github.com> * [Storage][STG75]Lease on Get/Set Tags & Find Blob by Tags (#15090) * [Storage][STG75]Lease on Get/Set Tags & Find Blob by Tags * pylint * [Fileshare] Share enable protocol share squash root (#15048) * generated root squash swagger * added api version * added new params * fixed valueerror * rerecorded * docstring fix * fixed docstrings * added sync tests * added async tests * fixed docstrings * renamed params and class * renamed params * renamed enabled protocols to protocols * fixed tests * fixed the validation issue * changed models to support list[str] * added tests * changed models type * [Blob] Added upload blob from url feature (#15027) * fixed swagger and added put blob * added method signitures * added str * added more kwargs docstrings * finished adding kwargs * return type * implemented new api * BlockBlob client fix * renamed param * renamed param * added content length * test experiment * added tests sync * added all tests * attempting to fix ci * added if tags match cond keyword * added more tests * added extra header * added more tests and removed keywords * recorded sync tests * added async tests * fixed import issue * rerecorded test * changed docstring * added overwrite and tests * rerecorded * cleaned up options method * cleaned up options method some more * fixed merge conflict * marked playback only for fileshares Co-authored-by: Xiaoxi Fu <49707495+xiafu-msft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.