Skip to content

Add Changelog Verification to Python - #15274

Merged
Chidozie Ononiwu (chidozieononiwu) merged 1 commit into
Azure:masterfrom
chidozieononiwu:feature/HookUpChangeLogVerification
Nov 16, 2020
Merged

Add Changelog Verification to Python#15274
Chidozie Ononiwu (chidozieononiwu) merged 1 commit into
Azure:masterfrom
chidozieononiwu:feature/HookUpChangeLogVerification

Conversation

@chidozieononiwu

Copy link
Copy Markdown
Member

This add changelog verification to the analyze and release stages of the python pipeline.
Fixes #12566

Comment thread eng/scripts/Language-Settings.ps1 Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we add a changelog and fix it here instead of trying to skip it?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I initially set out to do but Scott Beddall (@scbedd) says there is a reason it has no version/ changelog file.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Laurent Mazuel (@lmazuel) Scott Beddall (@scbedd) can you one of you guys provide more information on why this package doesn't have a ChangeLog?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wes Haggard (@weshaggard) nspkgs are published exactly once. There is very little functional reason to maintain a changelog for it.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will note that the way that that Dozie implemented it can be skipped individually on the artifact basis. That'll definitely work for this purpose.

Comment thread eng/pipelines/templates/steps/analyze.yml Outdated
- task: PythonScript@0
displayName: 'Verify Change Log'
inputs:
scriptPath: 'scripts/devops_tasks/verify_change_log.py'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it time to also remove the verify_change_log.py script?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chidozieononiwu
Chidozie Ononiwu (chidozieononiwu) merged commit faed399 into Azure:master Nov 16, 2020
@mitchdenny

Copy link
Copy Markdown
Contributor

@chidozieononiwu

Chidozie Ononiwu (chidozieononiwu) commented Nov 17, 2020

Copy link
Copy Markdown
Member Author

Looks like this may have broken the release pipelines:

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=621545&view=logs&j=68ad0081-6b61-5b6f-683b-31e991669c3b&t=c200186f-62f1-52d8-8dcb-eec32d16f6f6

For some reason it fails to retrieve the package properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable Change log check during release and analyse step

4 participants