Skip to content

Add Changelog Verification to Python #15274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chidozie Ononiwu (chidozieononiwu) merged 1 commit into from
Nov 16, 2020
Merged

Add Changelog Verification to Python #15274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions eng/pipelines/templates/jobs/archetype-sdk-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
parameters:
ServiceDirectory: ''
Artifacts: []
TestPipeline: false
BeforePublishSteps: []
TestMarkArgument: ''
Expand Down Expand Up @@ -92,6 +93,7 @@ jobs:
BuildTargetingString: ${{ parameters.BuildTargetingString }}
TestMarkArgument: ${{ parameters.TestMarkArgument }}
AdditionalTestArgs: '--wheel_dir="$(Build.ArtifactStagingDirectory)"'
Artifacts: ${{ parameters.Artifacts }}

- job: 'Test'
condition: and(succeededOrFailed(), ne(variables['Skip.Test'], 'true'))
Expand Down
6 changes: 6 additions & 0 deletions eng/pipelines/templates/stages/archetype-python-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,12 @@ stages:
pwsh: true
workingDirectory: $(Build.SourcesDirectory)
filePath: eng/scripts/SetTestPipelineVersion.ps1
- ${{if ne(artifact.skipVerifyChangeLog, 'true')}}:
- template: /eng/common/pipelines/templates/steps/verify-changelog.yml
parameters:
PackageName: ${{artifact.name}}
ServiceName: ${{parameters.ServiceDirectory}}
ForRelease: true
- template: /eng/pipelines/templates/steps/stage-filtered-artifacts.yml
parameters:
SourceFolder: ${{parameters.ArtifactName}}
Expand Down
1 change: 1 addition & 0 deletions eng/pipelines/templates/stages/archetype-sdk-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ stages:
- template: ../jobs/archetype-sdk-client.yml
parameters:
ServiceDirectory: ${{ parameters.ServiceDirectory }}
Artifacts: ${{ parameters.Artifacts }}
TestPipeline: ${{ parameters.TestPipeline }}
ToxEnvParallel: ${{ parameters.ToxEnvParallel }}
BuildDocs: ${{ parameters.BuildDocs }}
Expand Down
20 changes: 8 additions & 12 deletions eng/pipelines/templates/steps/analyze.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,18 @@ parameters:
ServiceDirectory: ''
TestMarkArgument: ''
AdditionalTestArgs: ''
Artifacts: []

steps:
- template: /eng/pipelines/templates/steps/analyze_dependency.yml

- task: PythonScript@0
displayName: 'Verify Change Log'
inputs:
scriptPath: 'scripts/devops_tasks/verify_change_log.py'

@weshaggard Wes Haggard (weshaggard) Nov 14, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it time to also remove the verify_change_log.py script?

@chidozieononiwu Chidozie Ononiwu (chidozieononiwu) Nov 16, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praveen Kuttappan (@praveenkuttappan)

arguments: '"${{ parameters.BuildTargetingString }}" --service=${{parameters.ServiceDirectory}}'
- ${{ each artifact in parameters.Artifacts }}:
Comment thread
chidozieononiwu marked this conversation as resolved.
Outdated
- ${{if ne(artifact.skipVerifyChangeLog, 'true')}}:
- template: /eng/common/pipelines/templates/steps/verify-changelog.yml
parameters:
PackageName: ${{artifact.name}}
ServiceName: ${{parameters.ServiceDirectory}}
ForRelease: false

# Using --always-succeed so as not to block the build. Once package
# target is based on data available per-package the --always-succeed should
Expand All @@ -26,13 +29,6 @@ steps:
- template: /eng/common/pipelines/templates/steps/verify-path-length.yml
parameters:
SourceDirectory: $(Build.SourcesDirectory)

- ${{ each artifact in parameters.Artifacts }}:
- template: /eng/common/pipelines/templates/steps/verify-changelog.yml
parameters:
PackageName: ${{artifact.name}}
ServiceName: ${{parameters.ServiceDirectory}}
ForRelease: false

- task: ms.vss-governance-buildtask.governance-build-task-component-detection.ComponentGovernanceComponentDetection@0
# ComponentGovernance is currently unable to run on pull requests of public projects. Running on non-PR
Expand Down
1 change: 1 addition & 0 deletions sdk/tables/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,5 @@ extends:
safeName: azuredatatables
- name: azure_data_nspkg
safeName: azuredatanspkg
skipVerifyChangeLog: true