Refactor Build, Versioning into azure-sdk-tools - #25454
Merged
Merged
Conversation
* moving versioning and build files to their appropriate location, adding azci namespace to azure-sdk-tools and getting argparsers working with each other * there is no path to successful completion of "build" command yet, that's next.
…king for the current level of abstraction and finish build.py
…wn concrete thoughts on implementation
… stuff yet though
…ng requirements, classifiers, and version to dev versions
…e if __name__ == main into callable functions, and we'll be in business!
… the versioning scripts
…bjects (which massively simplifies reading the code). update Language-Settings incorrect consumption of sdk_set_dev_version to sdk_set_version
… tox_harness, setup_execute_tests, test_regression
…imary entrypoint scripts
Scott Beddall (scbedd)
marked this pull request as ready for review
July 30, 2022 00:24
Scott Beddall (scbedd)
requested review from
Ben Broderick Phillips (benbp) and
Wes Haggard (weshaggard)
as code owners
July 30, 2022 00:24
Laia Patiño (laiapat)
approved these changes
Aug 12, 2022
…ast regression failures
… this will repair the regression in core
Member
Author
|
The failures present on |
Member
Author
|
The single failure during release is due to a known issue with the SemVer powershell scripts, and is not related to the refactor. Overriding and merging. |
Member
Author
|
/check-enforcer override |
Scott Beddall (scbedd)
added
the
Central-EngSys
Laia Patiño (laiapat)
pushed a commit
to laiapat/azure-sdk-for-python
that referenced
this pull request
Sep 22, 2022
* SDK-Tools refactor * Refactors scripts present under eng/versioning to namespace ci_tools.versioning within the azure-sdk-tools package. All Integration points in CI are flipped over to consume entrypoints defined in the setup.py. * Refactors build_packages.py and build_package.py into single module ci_tools.build. This function create_package within this module is used wherever packages are built. * Moves anything related to setup.py parsing into ci_tools.parsing. More specifically, allows users access to ParsedSetup which has a classmethod from_path that can be aimed at any setup.py or package root. * Instead of a crazy tuple that we can get lost in the sauce in, it's just strongly typed members of a class now. * Moves anything related to processing of requirements into ci_tools.functions. * Type and doc comment all the moved common functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR...
eng/versioningto namespaceci_tools.versioningwithin the azure-sdk-tools package. All Integration points in CI are flipped over to consume entrypoints defined in the setup.py.ci_tools.build. This functioncreate_packagewithin this module is used wherever packages are built.setup.pyparsing intoci_tools.parsing. More specific, allows users access toParsedSetupwhich has a classmethodfrom_paththat can be aimed at any setup.py. Instead of a crazy tuple that we can get lost in the sauce in, it's just strongly typed members of a class now.ci_tools.functions.This will be the most painful of the refactoring effort, but we will be able to make iterative fixes quite quickly once this one is in.
Due to the relative risk. I am delaying this merge until post-August-release-week. This is a significant improvement, but nothing that can't wait for a week.
Contributes to #23146