Resolve Failing Storage Builds - #25542
Merged
Scott Beddall (scbedd) merged 6 commits intoAug 4, 2022
Merged
Conversation
…h the requirement update for versions not found on pypi
Scott Beddall (scbedd)
requested review from
Ben Broderick Phillips (benbp) and
Wes Haggard (weshaggard)
as code owners
August 4, 2022 00:28
Laia Patiño (laiapat)
approved these changes
Aug 4, 2022
Laia Patiño (laiapat)
left a comment
Laia Patiño (laiapat)
left a comment
Member
There was a problem hiding this comment.
The regex is a little hairy, but it looks correct to me. The dev feed auth bit is more straightforward and makes sense 🙂
Co-authored-by: Scott Beddall <sbeddall@gmail.com>
…ference to pypi index
…edd/azure-sdk-for-python into hotfix/failing-storage-build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #25490
Friday of last week I noticed that azure-storage-file-datalake was having some issues on scheduled builds. The error was during installation, throwing out the fact that it couldn't resolve a version of
azure-storage-blobthat meats the requirements forazure-storage-file-datalake.There were two main problems at play here:
Issue for 2) is now properly resolved. Will definitely need to mirror this patch in the refactor PR
The core of the issue. We need up update the specifier to pull in an alpha package when the version is NOT on pypi. To do that, we do a string replacement operation.
azure-storage-blob<13.0.0,>=12.14.0b1->azure-storage-blob<13.0.0,>=12.14.0ab1Notice the
ab1that we were inserting? That's straight up wrong. I have implemented the regex to match PEP440The incorrect prerelease section
ab1is what was breaking pip's resolution.