Skip to content

Dont default to RequestsTransport - #25618

Merged
laiapat merged 6 commits into
mainfrom
fix/kv-core-imports
Aug 18, 2022
Merged

Dont default to RequestsTransport#25618
laiapat merged 6 commits into
mainfrom
fix/kv-core-imports

Conversation

@Stevenjin8

@Stevenjin8 Stevenjin8 commented Aug 9, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fix for #25533

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the KeyVault label Aug 9, 2022
@Stevenjin8

Stevenjin8 commented Aug 9, 2022

Copy link
Copy Markdown
Contributor Author

unsure how to test this

@Stevenjin8

Stevenjin8 commented Aug 9, 2022

Copy link
Copy Markdown
Contributor Author

/azp run python - keyvault - ci

@azure-pipelines

azure-pipelines Bot commented Aug 9, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@Stevenjin8
Stevenjin8 marked this pull request as ready for review August 9, 2022 21:06
@Stevenjin8 Stevenjin8 self-assigned this Aug 11, 2022
@Stevenjin8 Stevenjin8 mentioned this pull request Aug 11, 2022
Merged
laiapat
laiapat reviewed Aug 18, 2022
View reviewed changes

@laiapat laiapat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments also apply to async clients (and their async client bases -- example) 🙂

Comment thread ...eyvault/azure-keyvault-administration/azure/keyvault/administration/_internal/client_base.py Outdated
Comment thread sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_client.py Outdated
@Stevenjin8
Stevenjin8 requested a review from laiapat August 18, 2022 20:15
laiapat
laiapat approved these changes Aug 18, 2022
View reviewed changes

@laiapat laiapat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks again for tackling this 🙂

@azure-sdk

azure-sdk commented Aug 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-keyvault-certificates
azure-keyvault-keys
azure-keyvault-secrets

@Stevenjin8

Stevenjin8 commented Aug 18, 2022

Copy link
Copy Markdown
Contributor Author

Looks good to me! Thanks again for tackling this 🙂

Thanks @mccoyp. Please merge at your convenience.

@laiapat
laiapat merged commit 65ff178 into main Aug 18, 2022
@laiapat
laiapat deleted the fix/kv-core-imports branch August 18, 2022 21:20
laiapat pushed a commit to laiapat/azure-sdk-for-python that referenced this pull request Sep 22, 2022
Steven Jin @laiapat
[KV] Don't default to RequestsTransport (Azure#25618)
3707833
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laiapat laiapat laiapat approved these changes
@schaabs schaabs Awaiting requested review from schaabs
@YalinLi0312 YalinLi0312 Awaiting requested review from YalinLi0312

Assignees

@Stevenjin8 Stevenjin8

Labels

KeyVault

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Stevenjin8 @azure-sdk @laiapat