Skip to content

[TCGC] Support array encode on model property - #3583

Merged
tadelesh merged 3 commits into
mainfrom
array_encode
Dec 4, 2025
Merged

[TCGC] Support array encode on model property#3583
tadelesh merged 3 commits into
mainfrom
array_encode

Conversation

@tadelesh

@tadelesh tadelesh commented Nov 28, 2025

Copy link
Copy Markdown
Member

Resolve: #3534

@azure-sdk

azure-sdk commented Nov 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

All changed packages have been documented.

  • ✅ @azure-tools/typespec-client-generator-core
Show changes

@azure-tools/typespec-client-generator-core - feature ✏️

Support array encode on model property.

@pkg-pr-new

pkg-pr-new Bot commented Nov 28, 2025 •
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/Azure/typespec-azure/@azure-tools/typespec-client-generator-core@3583

commit: 1e8c3eb

@azure-sdk

azure-sdk commented Nov 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

You can try these changes here

🛝 Playground 🌐 Website

weidongxu-microsoft
weidongxu-microsoft reviewed Nov 28, 2025
View reviewed changes
Comment thread packages/typespec-client-generator-core/src/interfaces.ts
weidongxu-microsoft
weidongxu-microsoft reviewed Nov 28, 2025
View reviewed changes
Comment thread packages/typespec-client-generator-core/test/types/array.test.ts
lirenhe
lirenhe reviewed Nov 28, 2025
View reviewed changes
Comment thread packages/typespec-client-generator-core/test/types/array.test.ts
@weidongxu-microsoft weidongxu-microsoft mentioned this pull request Dec 2, 2025
Closed
@tadelesh

tadelesh commented Dec 2, 2025

Copy link
Copy Markdown
Member Author

Pending discussions:

  1. Where to put the lint
  2. Whether to put the encode info in the array type or model property
  3. Whether TypeSpec will put the build-in array encode type

@tadelesh tadelesh self-assigned this Dec 3, 2025
JialinHuang803
JialinHuang803 reviewed Dec 3, 2025
View reviewed changes
Comment thread packages/typespec-client-generator-core/src/types.ts
@tadelesh
tadelesh added this pull request to the merge queue Dec 4, 2025
@tadelesh

tadelesh commented Dec 4, 2025

Copy link
Copy Markdown
Member Author

Pending discussions:

  1. Where to put the lint
  2. Whether to put the encode info in the array type or model property
  3. Whether TypeSpec will put the build-in array encode type
  1. TypeSpec will add the lint. Issue here.
  2. Still keep in model property to keep extensibility.
  3. Nope. So, keep current TCGC type.

Merged via the queue into main with commit 10251be Dec 4, 2025
26 checks passed
@tadelesh
tadelesh deleted the array_encode branch December 4, 2025 03:06
@msyyc msyyc mentioned this pull request Dec 5, 2025
Merged
github-merge-queue Bot pushed a commit to microsoft/typespec that referenced this pull request Dec 12, 2025
@msyyc
[Python] Support encode for array of string in serialization and dese…
08179f6 
…rialization (#9146)

fix #9026

TCGC is ready: Azure/typespec-azure#3583

Spector case: #9106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JialinHuang803 JialinHuang803 JialinHuang803 left review comments
@lirenhe lirenhe lirenhe approved these changes
@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes
@msyyc msyyc msyyc approved these changes
@haolingdong-msft haolingdong-msft haolingdong-msft approved these changes
@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner
@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner
@iscai-msft iscai-msft Awaiting requested review from iscai-msft iscai-msft is a code owner
@srnagar srnagar Awaiting requested review from srnagar
@joheredi joheredi Awaiting requested review from joheredi
@bterlson bterlson Awaiting requested review from bterlson
@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner
@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

Assignees

@tadelesh tadelesh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CSV encoding for model properties TCGC Implementation

7 participants

@tadelesh @azure-sdk @lirenhe @weidongxu-microsoft @msyyc @haolingdong-msft @JialinHuang803