Skip to content

Adding explicit unlocking using portalocker - #43

Merged
Abhidnya (abhidnya13) merged 7 commits into
devfrom
portalocker_fix
Apr 10, 2020
Merged

Adding explicit unlocking using portalocker#43
Abhidnya (abhidnya13) merged 7 commits into
devfrom
portalocker_fix

Conversation

@abhidnya13

Copy link
Copy Markdown
Contributor

Resolves #42

Comment thread msal_extensions/cache_lock.py Outdated
Comment thread msal_extensions/cache_lock.py Outdated
Comment thread msal_extensions/cache_lock.py
@abhidnya13

Copy link
Copy Markdown
Contributor Author

@rayluo Ray Luo (rayluo) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Abhidnya (@abhidnya13) ! Your effort on testing on Mac and founding the significance of that LOCK_NB flag saves us from a future bugfix!

Comment thread msal_extensions/cache_lock.py Outdated
Co-Authored-By: Ray Luo <rayluo@microsoft.com>
@abhidnya13
Abhidnya (abhidnya13) merged commit 5d22932 into dev Apr 10, 2020
@abhidnya13
Abhidnya (abhidnya13) deleted the portalocker_fix branch April 10, 2020 20:45
@rayluo Ray Luo (rayluo) mentioned this pull request Apr 15, 2020
@bluca

Copy link
Copy Markdown
Contributor

Abhidnya (@abhidnya13) Ray Luo (@rayluo) just to be sure, what happens on Linux if portalocker doesn't have the fix? Will something break, or will it be an issue only in Windows?

@rayluo

Copy link
Copy Markdown
Contributor

Luca Boccassi (@bluca) According to #42, the specific issue, i.e. lock file is not being deleted, is only reported in Windows.

Did you observe any issue on Linux? If so, what is the symptom? Please create a new issue to describe it.

@bluca

Copy link
Copy Markdown
Contributor

Luca Boccassi (@bluca) According to #42, the specific issue, i.e. lock file is not being deleted, is only reported in Windows.

Did you observe any issue on Linux? If so, what is the symptom? Please create a new issue to describe it.

I did not see any issue - I am wondering whether I need to enforce the dependency on Linux or not when uploading the new version to Debian/Ubuntu.

@rayluo

Copy link
Copy Markdown
Contributor

Luca Boccassi (@bluca) If you are using this MSAL Extensions for Python library, it already enforces that dependency (on all platforms, for that matter). If you are using portalocker directly, you can make that decision. You may even open an issue in that repo and hear the input from its author, who is very responsive to github issues.

@bluca

Copy link
Copy Markdown
Contributor

Luca Boccassi (@bluca) If you are using this MSAL Extensions for Python library, it already enforces that dependency (on all platforms, for that matter).

No, it doesn't - unless I make it. Hence the question - should it? Is it really necessary for Linux?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The cache lock cannot be removed on Windows 10 if placed inside the user home directory.

5 participants