DX-2699 Add <StartStream> and <StopStream> BXML Verbs#97
Merged
ajrice6713 merged 7 commits intomainfrom Aug 29, 2022
Merged
Conversation
bpateldx
previously approved these changes
Aug 1, 2022
bandwidth/tests/test_bxml.py
Outdated
| username='username', | ||
| password='password' | ||
| ) | ||
| start_stream_response.add_verb(start_stream) |
There was a problem hiding this comment.
+1 for adding Unit Test.
Couple of things:
- The single test can be separated into two one for
start_streamand other forstop_stream - The property values can be extracted to their own variables and then both can be referenced in
expectedandactualobjects with a single source of truth
brianluisgomez
previously approved these changes
Aug 1, 2022
bpateldx
previously approved these changes
Aug 1, 2022
ajrice6713
dismissed stale reviews from bpateldx and brianluisgomez
via
c67638f
bpateldx
approved these changes
Aug 3, 2022
brianluisgomez
approved these changes
Aug 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.