Skip to content

DX-2699 Add <StartStream> and <StopStream> BXML Verbs #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajrice6713 merged 7 commits into from
Aug 29, 2022
Merged

DX-2699 Add <StartStream> and <StopStream> BXML Verbs #97

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d39b161
DX-2699 add `StartStream` and `StopStream` verbs
ajrice6713 Aug 1, 2022
47c1a36
Add tests
ajrice6713 Aug 1, 2022
0679e92
Fix URL Typos in test values
ajrice6713 Aug 1, 2022
800db7d
Apply Comments from Code Review
ajrice6713 Aug 1, 2022
18609e2
`verbs` -> `verb`
ajrice6713 Aug 1, 2022
c67638f
Add `tracks`
ajrice6713 Aug 3, 2022
8ae353c
Missing `,`
ajrice6713 Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
verbs -> verb
  • Loading branch information
@ajrice6713
ajrice6713 committed Aug 1, 2022
commit 18609e2b8313ed6941f012c537c80ac5f6ae14f7
4 changes: 2 additions & 2 deletions bandwidth/tests/test_bxml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ def test_generate_transfer_bxml_verb(self):
'asdf', 'c-93d6f3c0-be584596-0b74-4fa2-8015-d8ede84bd1a4')
assert actual == expected

def test_start_stream_bxml_verbs(self):
def test_start_stream_bxml_verb(self):
expected = '<?xml version="1.0" encoding="UTF-8"?><Response><StartStream destination="https://www.test.com/stream" name="test_stream" streamEventUrl="https://www.test.com/event" streamEventMethod="POST" username="username" password="password"/></Response>'
response = Response()
start_stream = StartStream(
Expand All @@ -424,7 +424,7 @@ def test_start_stream_bxml_verbs(self):

assert expected == actual

def test_stop_stream_bxml_verbs(self):
def test_stop_stream_bxml_verb(self):
expected = '<?xml version="1.0" encoding="UTF-8"?><Response><StopStream name="test_stream"/></Response>'
response = Response()
stop_stream = StopStream(
Expand Down