Fix typography audit issues#1185
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Important Review skippedToo many files! This PR contains 105 files, which is 5 over the limit of 100. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (105)
You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd641579f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <<<<<<< ours | ||
| <<<<<<< ours | ||
| <<<<<<< ours |
There was a problem hiding this comment.
Importing this route now reaches raw <<<<<<</=======/>>>>>>> tokens before the JavaScript parser can load it, so the application cannot compile. git diff --check also finds committed markers in the upload route, several production components, tests, and documentation; resolve each conflict and retain only the intended implementation.
Useful? React with 👍 / 👎.
| publisher_code: canonicalAuthority ? (identityAuthority.code ?? canonicalAuthority.codes[0] ?? null) : null, | ||
| publisher: canonicalAuthority?.publisher ?? null, | ||
| jurisdiction: canonicalAuthority?.jurisdictions[0] ?? "Australia/WA", |
There was a problem hiding this comment.
When an authenticated user uploads an arbitrarily named file such as EMHS-guideline.pdf, this user-controlled filename is converted into the canonical EMHS publisher code. The new classifier then designates that metadata as Official without requiring local validation, and the UI describes it as an authenticated health-service source, so a renamed document can receive false provenance. Keep uploads unclassified until publisher identity is verified by a trusted workflow; a focused upload-route test should prove that a filename token alone cannot grant an Official designation.
Useful? React with 👍 / 👎.
| navigateToMode(searchMode, { focus: true }); | ||
| } | ||
| }} | ||
| onMobileBack={() => router.back()} |
There was a problem hiding this comment.
On a direct mobile visit to an information route such as /forms/<slug> or /services/<slug>, this back control now calls router.back(), which can do nothing or return the user to an external site instead of the relevant mode home; the same commit also removes the form page's canonical fallback button. Restore the former route-specific router.push destinations (and the query-clearing mode-home behavior) so the app's only visible mobile back action remains an internal navigation path.
AGENTS.md reference: AGENTS.md:L192-L195
Useful? React with 👍 / 👎.
1 participant
Fixes for issues identified in the typography layout audit report.