Fix typography audit issues (clean supersede of #1185)#1200
Conversation
Prettier wraps the expanded font-sans stack and collapses the mockup heading so the push format guard passes. Ledger records the fresh Bugbot/review verdict on contaminated #1185 and the clean replacement.
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reached
Next review available in: 49 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Append ledger outcome for head 6bc0569: not ready due to nested heading hierarchy regression and draft/CI blockers.
Keep sheet/modal titles as h3 under Section h2 so the mockup stays h1 → h2 → h3. Add PR_POLICY_BODY.md with the typography summary so Sync PR policy body stops reapplying the unrelated audit-remediation description.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #5589 (success). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
Sources Find failed Production UI because open-focus retries would not move off the close control once a late-mounted data-sheet-autofocus input appeared. Allow that upgrade during the open retry window and cover it with a Sheet DOM regression test. Drop temporary PR policy body template after the live description was restored.
Merge-union left two identical ledger-066/067 READY records; the static ledger guard rejects exact duplicates. Keep the first copy and record the correction.
BigSimmo
added
the
skip-branch-sync
Retries previously stopped as soon as the close-button fallback held focus, so late-mounted data-sheet-autofocus inputs (Sources Find) never received focus. Only preferred autofocus/initialFocus targets end the retry loop early now.
Results-ribbon Sources still missed autofocus after Sheet settled on Close. Focus the Find field in useLayoutEffect, extend Sheet open retries to 4s, and give the smoke poll 15s.
Resolve Sheet/ui-smoke conflicts by taking main's stronger open-focus defense (full-window retries) and toBeFocused waiter. Keep DocumentDrawer mount focus. Drop exact-duplicate ledger rows from union merge.
|
Hygiene review (2026-07-26): this PR is MERGEABLE against current main with green required checks (or Production UI finishing). Prior contaminated Antigravity originals were closed; this clean supersede/fix is the intended land path. No code change from this note — ready for human merge when review/blockers clear. |
1 participant
Summary
Clean re-delivery of the intentional typography audit tip from closed PR #1185, cherry-picked onto current
main.Scope:
--font-sansfallback stack inglobals.css(Geist remains first)min-w-0on recent-search chipsleading-tighton bedside sheet titletabular-numson clinical console abbrevdata-sheet-autofocus(Sources Find) can upgrade off the close-button fallback — unblocks Production UI smoke that failed twice on this tipNested answer-evidence mockup titles stay at
h3under sectionh2.RAG impact: no retrieval behaviour change — CSS/mockup typography plus Sheet focus retry upgrade only.
Verification
npm run verify:cheapon cherry-pick tip (lint/typecheck/static; unit suite aside from known env flakes)node scripts/run-vitest.mjs run tests/sheet.dom.test.tsx(5/5) after autofocus fix7a9487774npm run verify:pr-local/verify:uilocally (hosted Production UI is the Chromium gate)Risk and rollout
Notes