Implement Audit Recommendations#1186
Conversation
|
Important Review skippedToo many files! This PR contains 114 files, which is 14 over the limit of 100. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (114)
You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8637fec36d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| max_upload_mb: env.MAX_UPLOAD_MB, | ||
| confidentiality_scope: "guidelines-only", | ||
| content_hash: contentHash, | ||
| <<<<<<< ours |
There was a problem hiding this comment.
The committed <<<<<<< ours block leaves this production route as invalid TypeScript, so importing the upload handler, type-checking, or building the application fails before uploads can be served. The commit-tree scan also finds unresolved markers in the answer route and several production components, so all conflict blocks need to be resolved rather than committing both alternatives.
Useful? React with 👍 / 👎.
| if (Date.now() - mtime > 30 * 60 * 1000) { | ||
| isStale = true; |
There was a problem hiding this comment.
When a heavyweight command runs for more than 30 minutes, this marks its lock stale even though its PID is alive: run-heavy.mjs waits using spawnSync, which blocks the parent event loop and prevents the new setInterval heartbeat from updating owner.json. A second invocation can consequently remove the live lock and start another heavyweight command concurrently; retain the live-PID check as authoritative or move the heartbeat to a mechanism that runs while the synchronous child is active.
AGENTS.md reference: AGENTS.md:L167-L168
Useful? React with 👍 / 👎.
| for (const branch of branchesToDelete) { | ||
| console.log(`Deleting merged branch: ${branch}`); | ||
| try { | ||
| run(`git branch -d ${branch}`); |
There was a problem hiding this comment.
When a merged local branch contains shell metacharacters, this template passes the ref through execSync's shell rather than as one Git argument. Git accepts names such as topic;id, so running npm run branch:cleanup can execute the suffix as a separate command instead of deleting only that ref; invoke Git with an argument array, such as execFileSync, to preserve the branch name literally.
Useful? React with 👍 / 👎.
|
Closed as superseded without merging. Intentional audit fixes were ported onto current |
* fix(audit): port safe #1186 remediation onto current main Supersede conflicted PR #1186 by landing only the intentional audit fixes: library-health skeleton/CLS, eval concurrency without duplicate bindings, async heavy-run lock heartbeats with force/stale reclaim, dry-run branch cleanup, and skill-create scaffolding with the interface openai.yaml shape. * docs(ledger): record #1186 superseding remediation review * docs(ledger): record #1186 close and #1209 CI green * docs(ledger): record #1186 closeout and #1209 CI green
1 participant
Resolves audit findings related to Git hygiene, UI CLS, and RAG evaluation parallelization.
Addresses the following issues: