Skip to content

docs: branch-review ledger for #1153 babysit#1194

Merged
BigSimmo merged 5 commits into
mainfrom
codex/pr-babysit-ledger
Jul 25, 2026
Merged

docs: branch-review ledger for #1153 babysit#1194
BigSimmo merged 5 commits into
mainfrom
codex/pr-babysit-ledger

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Jul 25, 2026

Copy link
Copy Markdown
Owner

Summary

  • Audit remediation: IPv6/port client-IP normalization, defensive semantic-rerank score clamping, PWA BroadcastChannel update signaling, heavyweight test-run lock live-owner preservation, PDF extractor signal handling, and fixed skill-catalog count pins.

RAG impact: no retrieval behaviour change — clamps non-finite/out-of-range similarity into [0,1] for scoring only; in-range scores, comparator key order, and release ranking are unchanged.

Verification

  • Focused: node scripts/run-vitest.mjs run tests/test-runner-safety.test.ts (17/17)
  • Focused: node scripts/run-vitest.mjs run tests/database-skills.test.ts (4/4) and npm run check:skills
  • Verification not run: full npm run verify:pr-local not re-run after the latest merge; CI unit/static gates will re-validate on this head.
  • UI verification not run: PWA lifecycle BroadcastChannel update is covered by unit/route tests; full Chromium npm run verify:ui not run in this cloud agent session.

Risk and rollout

  • Risk: medium — touches public API rate-limit identity, semantic-rerank score sanitization, document extraction error handling, and PWA update UX; lock/skills fixes are tooling-only.
  • Rollback: after squash-merge, revert the single squash commit on main; no schema/migration dependency.
  • Provider or production effects: None

Clinical Governance Preflight

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Notes

  • Review P1 live-lock reclaim and P2 skill-catalog tautology were fixed and resolved on-thread.
  • PR_POLICY_BODY.md exists so CI Sync PR policy body can write this description (agent token cannot edit the live PR body directly). Safe to delete after policy is green if you do not want the sync template retained.

Co-authored-by: Cursor <cursoragent@cursor.com>
@supabase

supabase Bot commented Jul 25, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Appends a branch-review ledger row for audit-remediation (PR #1153), documenting remediation work, CI approval, merge commit 191b17d2f, branch deletion, and ancestry verification.

Changes

Branch review ledger

Layer / File(s) Summary
Append branch review record
docs/branch-review-ledger.md
Adds an append-only entry covering CodeRabbit fixes, wording updates, CI status, merge details, and branch cleanup.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: cursoragent, claude

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is mostly about unrelated code changes and does not accurately describe this append-only ledger update. Rewrite the summary, verification, risk, and notes to describe the docs-only ledger append for PR #1153, and remove unrelated code-change details.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the actual change: an update to the branch-review ledger for PR #1153.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/pr-babysit-ledger

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@BigSimmo
BigSimmo merged commit e4d88b4 into main Jul 25, 2026
18 checks passed
@BigSimmo
BigSimmo deleted the codex/pr-babysit-ledger branch July 25, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant