Local presence checks (#054) and canonical /tools entry (#007)#1178
Merged
Conversation
Introduce check:local-presence (optional --fill) for safety-identifier, query-hash, and deep-probe gaps without printing values, warn from production-readiness, and record #54 local progress plus #7 blocked on the Tools canonical entry decision. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Contributor
📝 WalkthroughWalkthroughAdds a ChangesLocal presence and readiness
Canonical Tools routing
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant ClinicalSidebar
participant appModeHomeHref
participant Router
User->>ClinicalSidebar: Select Tools
ClinicalSidebar->>appModeHomeHref: Resolve tools home
appModeHomeHref-->>ClinicalSidebar: /tools
ClinicalSidebar->>Router: Navigate and prefetch /tools
Router-->>User: Render canonical Tools route
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Annotate the env map as Record<string, string> so TypeScript accepts key access in the focused unit tests. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Contributor
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #5394 (success). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
Format local-presence files for Prettier, bump postcss past the <=8.5.17 advisory so dependency-scope audit can pass, and align nav, appModeHomeHref, universal-search, prefetch, sitemap, and reachability on /tools per PT-11. Archive #7; keep /?mode=tools as a mode alias.
Stop Sync PR policy from overwriting PR descriptions with unrelated search-performance text, and append the local review ledger outcome for this branch.
cursor
Bot
changed the title
Contributor
Agent follow-up (PR body was clobbered by stale
|
…-054-7cf3 Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Keep canonical /tools on the six-item rail; align ui-smoke expectations. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/check-local-presence.mjs`:
- Around line 244-271: The mergeFillIntoEnvLocal function must remove existing
assignments whose values fail meetsMinLength before appending regenerated
secrets, while preserving valid assignments. Update the text-building flow to
omit stale short KEY=value lines for regenerated gap names, avoiding duplicate
assignments and keeping parseEnvFile behavior unambiguous.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 58654b11-fb18-475c-93ba-0daecabc431f
📒 Files selected for processing (22)
docs/branch-review-ledger.mddocs/codebase-index.mddocs/operator-backlog.mddocs/outstanding-issues.mddocs/production-readiness-checklist.mddocs/site-map.mddocs/wiring-conventions.mdpackage.jsonscripts/check-local-presence.mjsscripts/generate-site-map.tsscripts/production-readiness.tssrc/components/clinical-dashboard/ClinicalSidebar.tsxsrc/components/clinical-dashboard/global-search-shell.tsxsrc/components/clinical-dashboard/use-dashboard-shell-actions.tssrc/lib/app-modes.tssrc/lib/universal-search.tstests/app-modes.test.tstests/favourites-auth-gate.dom.test.tsxtests/local-presence.test.tstests/production-readiness-offline.test.tstests/route-reachability.test.tstests/ui-smoke.spec.ts
💤 Files with no reviewable changes (1)
- tests/route-reachability.test.ts
Keep blocking npm audit for package-lock/.npmrc only. Update phone Tools mode-menu smoke to expect canonical /tools navigation (PT-11). Co-authored-by: Cursor <cursoragent@cursor.com>
BigSimmo
added a commit
that referenced
this pull request
Jul 25, 2026
Same unblock as #1178: blocking npm audit keys off package-lock/.npmrc only. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/branch-review-ledger.md (1)
813-814: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winClarify the
check:local-presencestatus across these ledger rows.Lines 813–814 say
check:local-presence ok, while line 828 says the npm script was not registered until a later post-merge remediation. If the earlier check invokednode scripts/check-local-presence.mjsdirectly, state that explicitly; otherwise, revise the earlier rows so the history does not imply the npm script was already available.Also applies to: 828-828
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/branch-review-ledger.md` around lines 813 - 814, Clarify the `check:local-presence` status in the affected ledger rows: if the earlier verification ran `node scripts/check-local-presence.mjs` directly before the npm script existed, state that explicitly; otherwise revise those rows to avoid implying the `check:local-presence` npm script was available. Keep the later remediation entry consistent with this history.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@docs/branch-review-ledger.md`:
- Around line 813-814: Clarify the `check:local-presence` status in the affected
ledger rows: if the earlier verification ran `node
scripts/check-local-presence.mjs` directly before the npm script existed, state
that explicitly; otherwise revise those rows to avoid implying the
`check:local-presence` npm script was available. Keep the later remediation
entry consistent with this history.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 72d61ce3-ffcc-43c6-9ee5-9fecae2bcee4
📒 Files selected for processing (3)
docs/branch-review-ledger.mdpackage.jsontests/ui-smoke.spec.ts
🚧 Files skipped from review as they are similar to previous changes (2)
- tests/ui-smoke.spec.ts
- package.json
Avoid duplicate KEY=value lines when regenerating below-minLength secrets. Co-authored-by: Cursor <cursoragent@cursor.com>
Extend Sheet open-focus retries and skip composer focus=1 hydration while a modal dialog is open. Co-authored-by: Cursor <cursoragent@cursor.com>
BigSimmo
added a commit
that referenced
this pull request
Jul 25, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
BigSimmo
added a commit
that referenced
this pull request
Jul 25, 2026
* docs: ledger row for merged PR #1153 babysit Co-authored-by: Cursor <cursoragent@cursor.com> * docs: ledger rows for merged PRs #1153 and #1178 Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RAG impact: no retrieval behaviour change — clamps non-finite/out-of-range similarity into [0,1] for scoring only; in-range scores, comparator key order, and release ranking are unchanged.
Verification
node scripts/run-vitest.mjs run tests/test-runner-safety.test.ts(17/17)node scripts/run-vitest.mjs run tests/database-skills.test.ts(4/4) andnpm run check:skillsnpm run verify:pr-localnot re-run after the latest merge; CI unit/static gates will re-validate on this head.npm run verify:uinot run in this cloud agent session.Risk and rollout
Clinical Governance Preflight
Clinical KB Database(sjrfecxgysukkwxsowpy)Notes
PR_POLICY_BODY.mdexists so CI Sync PR policy body can write this description (agent token cannot edit the live PR body directly). Safe to delete after policy is green if you do not want the sync template retained.