Skip to content

Improve formulation builder disabled-state accessibility#1219

Closed
BigSimmo wants to merge 8 commits into
mainfrom
cursor/formulation-contrast-reconcile-14d4
Closed

Improve formulation builder disabled-state accessibility#1219
BigSimmo wants to merge 8 commits into
mainfrom
cursor/formulation-contrast-reconcile-14d4

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

  • replace opacity-only disabled styling on formulation builder navigation with explicit token-based disabled surfaces
  • preserve native disabled semantics while keeping labels readable in light, dark, and forced-colors modes
  • add Playwright coverage for disabled state, focus rejection, enabled transitions, and axe
  • record Create label.yml #64 as PR-prepared while leaving the unavailable historical worktree untouched

RAG impact: no retrieval behaviour change — UI-only disabled-state styling; no retrieval, ranking, answer, or source behavior changed.

Verification

  • npm run verify:pr-local — passed after merging freshly fetched origin/main; includes build, client-bundle secret scan, 3,419 unit tests, and offline RAG fixture validation
  • npm run verify:ui — ran 272/273 locally; all seven formulation journeys passed, with the sole failure being the unrelated PWA installability assertion reporting in-incognito because this environment substitutes system Chrome for absent managed Chromium
  • npm run verify:release — not run; provider-backed and not required for this UI-only change
  • Focused formulation Chromium: 2/2 passed after final main synchronization
  • Managed WebKit was unavailable locally; required hosted browser checks must be green before merge
  • npm run check:production-readiness was attempted and failed only because local Supabase/OpenAI environment variables are absent; no environment or provider behavior changed

Risk and rollout

  • Risk: Low — scoped Tailwind utility changes on two natively disabled buttons; no logic, API, data, auth, or clinical-output behavior changes.
  • Rollback: Revert 5696d114; no database or migration rollback is involved.
  • Provider or production effects: None.

Clinical Governance Preflight

N/A — UI-only disabled-state presentation; no ingestion, answer generation, retrieval/ranking, source rendering, document access, privacy, production environment, or clinical output behavior changed.

Notes

  • Two independent frontend/accessibility and regression reviews found no P0-P2 findings.
  • The historical agent/formulation-disabled-contrast worktree remains preserved but unavailable. This is a clean-room implementation and does not claim to have modified or discarded that source.
  • Merge only after all required hosted checks, especially managed-browser Production UI, are green.
Open in Web Open in Cursor 

cursoragent and others added 6 commits July 25, 2026 14:11
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
…ntrast-reconcile-14d4

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@supabase

supabase Bot commented Jul 25, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@cursor[bot], you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b4cfcd5d-0fe8-45c9-9309-c3aeea4b80c0

📥 Commits

Reviewing files that changed from the base of the PR and between b2d794c and acc39d0.

📒 Files selected for processing (4)
  • docs/branch-review-ledger.md
  • docs/outstanding-issues.md
  • src/components/formulation/formulation-builder-page.tsx
  • tests/ui-formulation.spec.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/formulation-contrast-reconcile-14d4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants