Skip to content

Improve formulation builder disabled-state accessibility#1223

Closed
BigSimmo wants to merge 4 commits into
mainfrom
cursor/formulation-disabled-accessibility-14d4
Closed

Improve formulation builder disabled-state accessibility#1223
BigSimmo wants to merge 4 commits into
mainfrom
cursor/formulation-disabled-accessibility-14d4

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

  • replace opacity-only disabled styling on formulation builder navigation with explicit token-based disabled surfaces
  • preserve native disabled semantics while keeping labels readable in light, dark, and forced-colors modes
  • add Playwright coverage for disabled state, focus rejection, enabled transitions, and axe
  • update Create label.yml #64 with the clean replacement disposition while leaving the unavailable historical worktree untouched

RAG impact: no retrieval behaviour change — UI-only disabled-state styling; no retrieval, ranking, answer, or source behavior changed.

Verification

  • npm run verify:pr-local — passed on the clean current-main branch; includes build, client-bundle secret scan, 3,421 unit tests, and offline RAG fixture validation
  • npm run verify:ui — equivalent product/test content passed all seven formulation journeys in PR Improve formulation builder disabled-state accessibility #1219; the prior local full run was 272/273 with only system Chrome’s unrelated PWA in-incognito result. This replacement requires clean hosted Production UI before merge.
  • npm run verify:release — not run; provider-backed and not required for this UI-only change
  • Focused formulation Chromium: 2/2 passed on this exact clean branch
  • npm run verify:cheap: 3,421/3,421 passed

Risk and rollout

  • Risk: Low — scoped Tailwind utility changes on two natively disabled buttons; no logic, API, data, auth, or clinical-output behavior changes.
  • Rollback: Revert 70dd8cd9; no database or migration rollback is involved.
  • Provider or production effects: None.

Clinical Governance Preflight

N/A — UI-only disabled-state presentation; no ingestion, answer generation, retrieval/ranking, source rendering, document access, privacy, production environment, or clinical output behavior changed.

Notes

Open in Web Open in Cursor 

cursoragent and others added 3 commits July 25, 2026 15:55
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@supabase

supabase Bot commented Jul 25, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@github-actions[bot], you've reached your PR review limit, so we couldn't start this review.

Next review available in: 15 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e3da648d-96c6-4018-b78a-11f5d1805c32

📥 Commits

Reviewing files that changed from the base of the PR and between 8ec2a3c and 259aeea.

📒 Files selected for processing (4)
  • docs/branch-review-ledger.md
  • docs/outstanding-issues.md
  • src/components/formulation/formulation-builder-page.tsx
  • tests/ui-formulation.spec.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/formulation-disabled-accessibility-14d4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

  • Production UIneeds investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
  • PR requiredneeds investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #5589 (success).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants