chore: prune dead mockup and primitive exports (IMP-04)#1241
Conversation
Delete unused calculator/factsheet helpers and ui-primitives tokens with zero external importers. Unexport in-file-only tokens. Keep Skeleton and the commandInput focus shadow from current main.
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reached
Next review available in: 23 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughReduced public exports across calculator mockups, factsheet modules, and shared UI primitives. Added rendered factsheet glyph helpers, removed an unused calculator hook, synchronized recipe guidance, and recorded the pruning work in the review ledger. ChangesDead export pruning
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Clean auto-merge after bot sync lagged main. No content conflicts with the dead-export prune; ledger union merge succeeded.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5a04654fcc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/branch-review-ledger.md`:
- Line 1036: Update the READY row for commit
4739510e8650e38e3c3a3cd2d8866dcf3abb8ab6 to record npm run ensure, npm run
verify:ui, the smallest relevant domain check, npm run
check:production-readiness, and the clinical governance preflight alongside the
existing typecheck and ESLint checks.
- Around line 1035-1036: Remove the blank line separating the new 2026-07-25
record from the surrounding Markdown table in the branch review ledger, keeping
the row directly adjacent to the other table rows so it renders as a Review
Records entry.
🪄 Autofix (Beta)
❌ Autofix failed (check again to retry)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 813698cb-d83a-467d-99ab-2585e2c66025
📒 Files selected for processing (6)
docs/branch-review-ledger.mdsrc/components/calculator-mockups/calculator-fixtures.tssrc/components/calculator-mockups/calculator-ui.tsxsrc/components/factsheets/factsheets-data.tssrc/components/factsheets/factsheets-icons.tssrc/components/ui-primitives.tsx
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. The agent ran but didn't make any changes. The issues may already be fixed or require manual intervention. |
|
Hygiene review (2026-07-26): this PR is MERGEABLE against current main with green required checks (or Production UI finishing). Prior contaminated Antigravity originals were closed; this clean supersede/fix is the intended land path. No code change from this note — ready for human merge when review/blockers clear. |
Update design-sync conventions and the ui-primitives recipe reference so they no longer advertise deleted or module-private recipes (insetCard, iconTile, compactMetadataRow, commandInput, toneWarningQuiet, etc.). Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/redesign/09-ui-primitives-recipes.md`:
- Around line 165-167: Update the gap-status paragraph in the UI primitives
recipes documentation to remove gap 5 from the unresolved “Remaining” list,
leaving only gap 2 as unresolved; if gap 5 must be mentioned, label it
separately as an accepted convention rather than a remaining gap.
- Around line 80-81: Update the `commandInput` removal note in the documented
catalogue to clarify that only the exported recipe/catalogue entry was removed;
retain and explicitly identify its focus-shadow styling as global class/layer
rules, not a re-exportable utility or recipe.
🪄 Autofix (Beta)
✅ Autofix completed
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 51960839-1036-4686-9ed8-274f814a13a7
📒 Files selected for processing (5)
.design-sync/conventions.mddocs/branch-review-ledger.mddocs/clinical-badge-system-guide.mddocs/design-system.mddocs/redesign/09-ui-primitives-recipes.md
🚧 Files skipped from review as they are similar to previous changes (1)
- docs/branch-review-ledger.md
Co-authored-by: Cursor <cursoragent@cursor.com>
Git merge-tree was clean (staleness). Accepts main #1227 calculator package relocation; calculator-mockups prune from this branch is superseded by that move and needs a separate re-port decision. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
GitHub CONFLICTING was staleness; merge-tree clean. Calculator rename from #1227 carried the IMP-04 prune onto src/components/calculators/. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
GitHub CONFLICTING was staleness behind phone-chrome and desktop-search fixes. merge-tree clean; only overlapping path is the append-only ledger. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. Fixes Applied SuccessfullyFixed 1 file(s) based on 1 unresolved review comment. Files modified:
Commit: The changes have been pushed to the Time taken: |
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. The agent ran but didn't make any changes. The issues may already be fixed or require manual intervention. |
Fixed 1 file(s) based on 1 unresolved review comment. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
…ad-exports-01f2 Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
…01f2' into cursor/imp04-prune-dead-exports-01f2
* fix: stop choppy screen resize when switching modes Mode switches animated phone composer reserve because searchMode updated before the pathname landed, briefly leaving isStandaloneModeHome false and running the 200ms padding transition. Detect mode homes from pathname only, navigate without optimistic mode state, and limit padding transitions to scroll-hide. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * test: align therapy-compass wiring with pathname mode-home gate Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * docs(ledger): record mode-switch lag same-class bug hunt Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * fix: close same-class mode-switch layout thrash bugs After the reserve-flip fix, related choppiness remained from eager crossModeSearch chrome updates, inherited phone scroll/hide across mode homes, a hero-portal null gap while slots rebound, a taller mode-home loading skeleton, and services/forms contentAlign jumping after registry load. Navigate out of the dashboard without rewriting chrome, reset scroll-hide on pathname change, keep the default composer until the portal attaches, align the skeleton to the shell header token, and keep loading homes top-aligned on phone. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * docs(ledger): record mode-switch thrash review fixes Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * fix: satisfy lint for mode-switch scroll and portal cleanup Reset bottom-composer hidden state during render on pathname change instead of setState-in-effect, and drop the unused hero-portal fallback flag now that the default composer stays mounted until the host attaches. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * docs(ledger): record mode-switch thrash lint closeout Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * docs(ledger): record frontend-architecture loading/nav review Append review of mode/page loading and navigation architecture at HEAD 0ef62ff: P1 shell bundle + hydration blanking; residual remount/tools dual. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * fix: reduce mode/page loading blanking and layout rework Parallel loading review found hard-load blanking from ClientHydrationBoundary, mismatched/missing mode-home loading skeletons, forms catalog in the client chunk, ClinicalDashboard static weight on namespaced routes, sidebar column animation on remount, forms query remounts, and document viewer remounts on page flips. Paint RSC children immediately, align ModeHomeRouteLoading, wire mode-home loading.tsx files, server-pass the default form slug, dynamic-import ClinicalDashboard, gate sidebar transitions after mount, and stop unnecessary remount keys. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * docs(ledger): record parallel loading behaviour review fixes Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * refactor: extract sidebar transition hook and private-scope URL helper Keeps ClinicalDashboard inside the maintainability budget after the loading-performance pass, and shares the remount-safe sidebar transition gate with GlobalSearchShell. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * test: allow DocumentViewer identity-only remount key Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * test: align chrome contracts with pathname reset and gated padding After merging main's cross-breakpoint scroll-hide wiring, update static contracts for resetKey=pathname, and keep phone padding transitions gated to scroll-hide only so mode switches still snap. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * fix: clear CI hydration and phone-scroll failures Gate desktop composer portal adoption until page-owned slots mark themselves ready after hydration, so hard-loads no longer inject a display:contents host into still-unhydrated RSC HTML (React #418). Update phone-scroll expectations for scroll-hide-only reserve transitions. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * style: prettier-format portal ready-gate files Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * fix: keep document searches dashboard-owned and animate reserve reveal Treat /documents/search as in-shell for cross-mode sync, keep a short-lived reserve-transition marker through hide and reveal, omit readiness cards without a default slug, and preserve URL hashes when clearing private scope refs. * fix: stop duplicate page-root testids from searchParams Suspense Nesting route children inside the shell's useSearchParams Suspense left a hidden Next streaming S: clone of forms/favourites/presentation roots under CI load. Gate always-standalone paths off that boundary and bridge params beside the shell body so mode-home RSC paint stays. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * style: prettier format DocumentViewer reserve-transition import * docs: record babysit sweep ledger rows for #1241/#1248/#1254/#1257/#1253/#1255 * refactor: extract DocumentViewer/Dashboard helpers under budgets Pull PDF viewer mode helpers and document chrome scroll wiring into focused modules, and isolate the dashboard desktop result composer slot, so maintainability no-growth budgets pass after the reserve-transition and portal ready-gate work. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * test: align desktop page-slot contract with extracted helper Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * fix: satisfy hooks lint for searchParams Suspense bridge Use useSyncExternalStore for the client-only gate and call the param callback from layout effect deps instead of updating a ref during render. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * fix: seed standalone submitted search params Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * test: stabilize phone-scroll and presentation page assertions Drop the settled-bottom 0.24s reserve check (transition is short-lived on data-reserve-transitioning), and scope differential presentation lookups to the live shell scrollport so hidden Next streaming clones cannot fail strict mode under CI load. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * fix: narrow submitted search param seeding Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2 participants
Summary
Ports the safe remaining follow-up from closed PR #1188 / tip commit
3bc391dff: remove dead calculator/factsheet mockup exports and unusedui-primitivestokens that have zero external importers on currentmain.This is not a blind cherry-pick of the rejected tip:
eslint --max-warnings 0).Skeletonand thecommandInputfocus shadow — the tip incorrectly removed/changed those while they are still used on main.Merge conflict note
GitHub showed
CONFLICTING/DIRTYbecause the branch laggedmain(staleness). Localgit merge origin/mainwas a clean auto-merge (ledgeruniondriver; no conflict markers; no opposing edits in IMP-04 product files). Synced tip:35decbc80. PR is nowMERGEABLE.Files
src/components/calculator-mockups/calculator-fixtures.tssrc/components/calculator-mockups/calculator-ui.tsxsrc/components/factsheets/factsheets-data.tssrc/components/factsheets/factsheets-icons.tssrc/components/ui-primitives.tsxdocs/branch-review-ledger.mdClinical Governance Preflight
src/lib/rag/**or ranking surfaces touched.Test plan
npm run typecheckeslinton touched files (--max-warnings 0)npm run check:branch-review-ledgerSummary by CodeRabbit
Accessibility
Style
Documentation