Skip to content

fix(therapy): remove search-page intro and local query field#1257

Merged
BigSimmo merged 2 commits into
mainfrom
cursor/therapy-search-trim-e63e
Jul 26, 2026
Merged

fix(therapy): remove search-page intro and local query field#1257
BigSimmo merged 2 commits into
mainfrom
cursor/therapy-search-trim-e63e

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Jul 26, 2026

Copy link
Copy Markdown
Owner

Summary

Removes the redundant Therapy search intro on /therapy-compass/search across all breakpoints:

  • Drop the Therapy heading and “Find source-grounded…” blurb
  • Drop the local in-page Search therapies input (library filtering still works via home/?q= deep links, topic/availability filters, and chips)
  • Promote SearchResultsHeaderBand to the page h1 so the route keeps a primary heading

Clinical governance preflight

  • Not applicable: UI-only Therapy search chrome change; no ingestion, answer generation, ranking, source rendering, document access, privacy, or clinical output changes.

Test plan

  • npm run test:focused -- --files tests/therapy-compass-mode-wiring.test.ts
  • Focused Playwright: therapy a11y + route coverage (or npm run verify:ui if runtime available)
  • Manual: /therapy-compass/search on phone + desktop — no intro/local input; ribbon + filters remain

Notes

Shell search chrome is unchanged. On-page typing against the therapy library is intentionally removed with this intro block; typed queries from the Therapy home still land via ?q=&run=1.

Open in Web Open in Cursor 

Summary by CodeRabbit

  • Updates
    • Refined the Therapy Compass search results header to provide a clearer results ribbon with proper heading semantics.
    • Removed redundant search-page title, description, and search-input layout elements.
    • Updated search results behavior to display the selected topic as the primary heading.
    • Improved accessibility checks for focus visibility and heading structure.
    • Updated responsive and route coverage for search result navigation.

Drop the Therapy heading, blurb, and duplicate in-page search input on
/therapy-compass/search so filters and results own the page. Promote the
results ribbon to h1 and update wiring/a11y/route coverage accordingly.
@supabase

supabase Bot commented Jul 26, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@BigSimmo, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0a17a91a-9b20-4850-a633-72b1e3985120

📥 Commits

Reviewing files that changed from the base of the PR and between 59bf6d6 and b80a381.

📒 Files selected for processing (1)
  • tests/therapy-compass-mode-wiring.test.ts
📝 Walkthrough

Walkthrough

Therapy Compass now renders the search results heading through SearchResultsHeaderBand at level 1, removes the standalone search header and related CSS, and updates wiring, accessibility, and route tests for the revised UI.

Changes

Therapy search results header

Layer / File(s) Summary
Search results header composition
src/components/therapy-compass/screens/search-screen.tsx, src/components/therapy-compass/therapy-compass.css
SearchResultsHeaderBand now receives headingLevel={1}, while the standalone search header, input block, unused icon import, and obsolete CSS rules are removed.
Search header validation
tests/therapy-compass-mode-wiring.test.ts, tests/ui-accessibility.spec.ts, tests/ui-route-coverage.spec.ts
Tests now validate the search results ribbon, absence of the search textbox, topic-filter focus styling, and the selected therapy heading.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested labels: codex

Suggested reviewers: claude, cursoragent

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately describes the main UI change on the therapy search page.
Description check ✅ Passed The description covers summary, testing, clinical preflight, and notes, but it does not follow the template’s Verification format exactly.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/therapy-search-trim-e63e

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@BigSimmo
BigSimmo marked this pull request as ready for review July 26, 2026 03:14
Keep the six-item sidebar invariant from main while asserting the search
route no longer owns the intro heading or local query field.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 59bf6d6532

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/therapy-compass-mode-wiring.test.ts Outdated
@BigSimmo

Copy link
Copy Markdown
Owner Author

@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. After fixing or dispositioning a thread, reply in that thread with as the first line, followed by a concise summary; that marker authorizes the workflow to close that exact thread. If human input or new authorization is required, do not use the marker and leave the thread open with the blocker. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: b80a381081

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BigSimmo
BigSimmo enabled auto-merge (squash) July 26, 2026 03:20
@BigSimmo
BigSimmo merged commit 024ebff into main Jul 26, 2026
50 checks passed
@BigSimmo
BigSimmo deleted the cursor/therapy-search-trim-e63e branch July 26, 2026 03:26
cursor Bot pushed a commit that referenced this pull request Jul 26, 2026
* fix: stop choppy screen resize when switching modes

Mode switches animated phone composer reserve because searchMode updated
before the pathname landed, briefly leaving isStandaloneModeHome false and
running the 200ms padding transition. Detect mode homes from pathname only,
navigate without optimistic mode state, and limit padding transitions to
scroll-hide.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

* test: align therapy-compass wiring with pathname mode-home gate

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

* docs(ledger): record mode-switch lag same-class bug hunt

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

* fix: close same-class mode-switch layout thrash bugs

After the reserve-flip fix, related choppiness remained from eager
crossModeSearch chrome updates, inherited phone scroll/hide across mode
homes, a hero-portal null gap while slots rebound, a taller mode-home
loading skeleton, and services/forms contentAlign jumping after registry
load. Navigate out of the dashboard without rewriting chrome, reset
scroll-hide on pathname change, keep the default composer until the
portal attaches, align the skeleton to the shell header token, and keep
loading homes top-aligned on phone.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

* docs(ledger): record mode-switch thrash review fixes

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

* fix: satisfy lint for mode-switch scroll and portal cleanup

Reset bottom-composer hidden state during render on pathname change
instead of setState-in-effect, and drop the unused hero-portal fallback
flag now that the default composer stays mounted until the host attaches.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

* docs(ledger): record mode-switch thrash lint closeout

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

* docs(ledger): record frontend-architecture loading/nav review

Append review of mode/page loading and navigation architecture at HEAD
0ef62ff: P1 shell bundle + hydration blanking; residual remount/tools dual.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

* fix: reduce mode/page loading blanking and layout rework

Parallel loading review found hard-load blanking from ClientHydrationBoundary,
mismatched/missing mode-home loading skeletons, forms catalog in the client
chunk, ClinicalDashboard static weight on namespaced routes, sidebar column
animation on remount, forms query remounts, and document viewer remounts on
page flips. Paint RSC children immediately, align ModeHomeRouteLoading, wire
mode-home loading.tsx files, server-pass the default form slug, dynamic-import
ClinicalDashboard, gate sidebar transitions after mount, and stop unnecessary
remount keys.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

* docs(ledger): record parallel loading behaviour review fixes

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

* refactor: extract sidebar transition hook and private-scope URL helper

Keeps ClinicalDashboard inside the maintainability budget after the
loading-performance pass, and shares the remount-safe sidebar transition
gate with GlobalSearchShell.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

* test: allow DocumentViewer identity-only remount key

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

* test: align chrome contracts with pathname reset and gated padding

After merging main's cross-breakpoint scroll-hide wiring, update static
contracts for resetKey=pathname, and keep phone padding transitions gated
to scroll-hide only so mode switches still snap.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

* fix: clear CI hydration and phone-scroll failures

Gate desktop composer portal adoption until page-owned slots mark
themselves ready after hydration, so hard-loads no longer inject a
display:contents host into still-unhydrated RSC HTML (React #418).
Update phone-scroll expectations for scroll-hide-only reserve transitions.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

* style: prettier-format portal ready-gate files

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

* fix: keep document searches dashboard-owned and animate reserve reveal

Treat /documents/search as in-shell for cross-mode sync, keep a short-lived reserve-transition marker through hide and reveal, omit readiness cards without a default slug, and preserve URL hashes when clearing private scope refs.

* fix: stop duplicate page-root testids from searchParams Suspense

Nesting route children inside the shell's useSearchParams Suspense left a
hidden Next streaming S: clone of forms/favourites/presentation roots under
CI load. Gate always-standalone paths off that boundary and bridge params
beside the shell body so mode-home RSC paint stays.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

* style: prettier format DocumentViewer reserve-transition import

* docs: record babysit sweep ledger rows for #1241/#1248/#1254/#1257/#1253/#1255

* refactor: extract DocumentViewer/Dashboard helpers under budgets

Pull PDF viewer mode helpers and document chrome scroll wiring into
focused modules, and isolate the dashboard desktop result composer slot,
so maintainability no-growth budgets pass after the reserve-transition
and portal ready-gate work.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

* test: align desktop page-slot contract with extracted helper

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

* fix: satisfy hooks lint for searchParams Suspense bridge

Use useSyncExternalStore for the client-only gate and call the param
callback from layout effect deps instead of updating a ref during render.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

* fix: seed standalone submitted search params

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

* test: stabilize phone-scroll and presentation page assertions

Drop the settled-bottom 0.24s reserve check (transition is short-lived on
data-reserve-transitioning), and scope differential presentation lookups to
the live shell scrollport so hidden Next streaming clones cannot fail strict
mode under CI load.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

* fix: narrow submitted search param seeding

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cursor Bot pushed a commit that referenced this pull request Jul 26, 2026
Append final land/close rows for the authorized open-PR triage:
closed unsafe audit tips #1255/#1253, and prlanded #1257/#1212/#1241/#1248/#1254/#1259.

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant