Improve formulation builder disabled-state accessibility#1249
Conversation
Replace opacity-based disabled styling on Previous/Continue with explicit token surfaces so unavailable nav stays readable and does not leave stale WebKit opacity after re-enable. Add focused Playwright coverage for native disabled state, opacity 1, focus rejection, and axe cleanliness. Update #64 and append a linear-replay ledger row after closing conflicted PR #1231. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reached
Next review available in: 12 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Keep the linear-replay #64 disposition formatting check-clean. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Pull request was closed
Summary
Replays the
#064formulation disabled-control accessibility fix on currentmainafter conflicted PRs#1219,#1223,#1226, and#1231were closed.disabled:opacity-*on Previous/Continue with explicit token surfaces (disabled:border,disabled:bg-[color:var(--surface-inset)], muted text/shadow for Continue)disabledso unavailable nav rejects focus and stays opacity1#064disposition and append one branch-review ledger rowHistorical
agent/formulation-disabled-contrastremains unrecovered/untouched.RAG impact: no retrieval behaviour change — formulation UI disabled styling and Playwright coverage onlyVerification
npm run verify:pr-local(running after PR open)tests/ui-formulation.spec.ts(running after PR open)verify:uideferred to hosted Production UI; local managed browsers may be incomplete in this environmentRisk and rollout
Notes
skip-branch-syncmaininto this branch after openMERGEABLEand required checks are green#1219/#1223/#1226/#1231