Skip to content

Improve formulation builder disabled-state accessibility#1249

Closed
BigSimmo wants to merge 3 commits into
mainfrom
cursor/formulation-a11y-replay-14d4
Closed

Improve formulation builder disabled-state accessibility#1249
BigSimmo wants to merge 3 commits into
mainfrom
cursor/formulation-a11y-replay-14d4

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

Replays the #064 formulation disabled-control accessibility fix on current main after conflicted PRs #1219, #1223, #1226, and #1231 were closed.

  • Replace disabled:opacity-* on Previous/Continue with explicit token surfaces (disabled:border, disabled:bg-[color:var(--surface-inset)], muted text/shadow for Continue)
  • Keep native disabled so unavailable nav rejects focus and stays opacity 1
  • Add Playwright coverage for native-disabled state, opacity, focus rejection, and axe cleanliness; keep the re-enabled Previous opacity guard in the draft journey
  • Update #064 disposition and append one branch-review ledger row

Historical agent/formulation-disabled-contrast remains unrecovered/untouched.

RAG impact: no retrieval behaviour change — formulation UI disabled styling and Playwright coverage only

Verification

  • npm run verify:pr-local (running after PR open)
  • focused Chromium tests/ui-formulation.spec.ts (running after PR open)
  • UI verification not run yet: full verify:ui deferred to hosted Production UI; local managed browsers may be incomplete in this environment
  • Verification not run: provider-backed / release gates (not required for this UI-only change)

Risk and rollout

  • Risk: Low — styling + test-only change to formulation builder step nav
  • Rollback: Revert the squash commit; previous opacity utilities return
  • Provider or production effects: None

Notes

  • Apply and keep skip-branch-sync
  • Do not merge main into this branch after open
  • Squash-merge only when GitHub reports MERGEABLE and required checks are green
  • Do not merge closed PRs #1219 / #1223 / #1226 / #1231
Open in Web Open in Cursor 

Replace opacity-based disabled styling on Previous/Continue with explicit
token surfaces so unavailable nav stays readable and does not leave stale
WebKit opacity after re-enable. Add focused Playwright coverage for native
disabled state, opacity 1, focus rejection, and axe cleanliness. Update #64
and append a linear-replay ledger row after closing conflicted PR #1231.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@BigSimmo BigSimmo added the skip-branch-sync Opt out of hosted pr-branch-sync / update-branch on this PR label Jul 26, 2026 — with Cursor
@supabase

supabase Bot commented Jul 26, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@BigSimmo, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 12 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 70b9dc40-97c8-4c54-870d-d240262ebb62

📥 Commits

Reviewing files that changed from the base of the PR and between 3c048fe and f5b16ca.

📒 Files selected for processing (4)
  • docs/branch-review-ledger.md
  • docs/outstanding-issues.md
  • src/components/formulation/formulation-builder-page.tsx
  • tests/ui-formulation.spec.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/formulation-a11y-replay-14d4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Keep the linear-replay #64 disposition formatting check-clean.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@BigSimmo
BigSimmo marked this pull request as ready for review July 26, 2026 01:49
@BigSimmo
BigSimmo enabled auto-merge (squash) July 26, 2026 01:49
@BigSimmo BigSimmo closed this Jul 26, 2026
auto-merge was automatically disabled July 26, 2026 01:53

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-branch-sync Opt out of hosted pr-branch-sync / update-branch on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants