Skip to content

Improve formulation builder disabled-state accessibility#1250

Merged
cursor[bot] merged 1 commit into
mainfrom
cursor/formulation-a11y-linear2-14d4
Jul 26, 2026
Merged

Improve formulation builder disabled-state accessibility#1250
cursor[bot] merged 1 commit into
mainfrom
cursor/formulation-a11y-linear2-14d4

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Jul 26, 2026

Copy link
Copy Markdown
Owner

Summary

Fresh linear replay of #064 on current main after conflicted/superseded PRs #1219, #1223, #1226, #1231, and #1249 were closed.

  • Replace disabled:opacity-* on Previous/Continue with explicit token surfaces
  • Keep native disabled so unavailable nav rejects focus and stays opacity 1
  • Add Playwright coverage for native-disabled state, opacity, focus rejection, and axe cleanliness
  • Update #064 disposition only (no ledger append in this PR to avoid merge=union collisions)

Historical agent/formulation-disabled-contrast remains unrecovered/untouched.

RAG impact: no retrieval behaviour change — formulation UI disabled styling and Playwright coverage only

Verification

  • Focused Chromium tests/ui-formulation.spec.ts7/7 on head 14b4e80e
  • npm run verify:cheap — green on head 14b4e80e (3473 tests)
  • npm run verify:pr-local — green on identical prior product patch (build, client-secret scan, offline RAG fixtures)
  • UI verification not run locally for full suite: rely on hosted Production UI
  • Verification not run: provider-backed / release gates (not required)

Risk and rollout

  • Risk: Low — styling + test-only change to formulation builder step nav
  • Rollback: Revert the squash commit
  • Provider or production effects: None

Notes

Open in Web Open in Cursor 

Replace opacity-based disabled styling on Previous/Continue with explicit
token surfaces so unavailable nav stays readable and does not leave stale
WebKit opacity after re-enable. Add focused Playwright coverage for native
disabled state, opacity 1, focus rejection, and axe cleanliness. Update #64
for the fresh linear branch after conflicted PRs were closed.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@BigSimmo BigSimmo added the skip-branch-sync Opt out of hosted pr-branch-sync / update-branch on this PR label Jul 26, 2026 — with Cursor
@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@BigSimmo, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 7 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c2c92a20-110f-453b-b201-e749e1877cdb

📥 Commits

Reviewing files that changed from the base of the PR and between 3c048fe and 14b4e80.

📒 Files selected for processing (3)
  • docs/outstanding-issues.md
  • src/components/formulation/formulation-builder-page.tsx
  • tests/ui-formulation.spec.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/formulation-a11y-linear2-14d4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@supabase

supabase Bot commented Jul 26, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@cursor
cursor Bot merged commit b91b460 into main Jul 26, 2026
20 of 21 checks passed
@cursor
cursor Bot deleted the cursor/formulation-a11y-linear2-14d4 branch July 26, 2026 02:02
cursor Bot pushed a commit that referenced this pull request Jul 26, 2026
Archive outstanding item #64 as landed via PR #1250, renumber the
recommended queue, and append the prlanded branch-review ledger row.

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-branch-sync Opt out of hosted pr-branch-sync / update-branch on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants