📝 Add docstrings to claude/site-formatting-polish-b91374#503
Merged
BigSimmo merged 3 commits intoJul 11, 2026
Merged
Conversation
…n taps Rebuilt on top of #483's redesigned interactive detail page (which already fixed the wrapping action labels and tab-label wrap). Remaining polish: - Add a .focus-ring-tab class (inset rounded ring: outline-offset -4px, no halo) so keyboard focus no longer draws a full-height box that collides with the tablist border; inactive tabs get a transparent bottom border to remove the 2px layout jump on tab switch. - Keep #483's roving-tabindex keyboard nav, nowrap and flex-1 layout intact. - shrink-0 on the desktop action cluster so the Save icon button stops being crushed below 44px at ~1024px; nowrap on the Compare button. - Bump the two overlap-diagnosis chips to the 44px tap standard. - Regression test: detail Save action >=44px at 1024px, Overview tab single-line with no page overflow at 320px. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…on routes Still-present defects confirmed by a fresh sweep of current main (15 routes x 7 widths); none were addressed by recent main changes: - DocumentTagCloud: drop the focus: ring classes that painted a ring on mouse click; the global :focus-visible rule keeps the keyboard ring. - applications launcher category filters: mobile 28px / desktop 36px -> 44px, with whitespace-nowrap. - service detail Copy row buttons: 40px -> 44px. - favourites command-library More-actions buttons and library sidebar rows and compact toggle: 36px -> 44px. Deliberately left main's intentional lg:min-h-9 desktop density on the mode-home quick-link pills (AA-compliant for pointer). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Docstrings generation was requested by @BigSimmo. * #494 (comment) The following files were modified: * `src/components/DocumentTagCloud.tsx` * `src/components/applications-launcher-page.tsx` * `src/components/clinical-dashboard/favourites-command-library-page.tsx` * `src/components/clinical-dashboard/favourites-library-nav.tsx` * `src/components/differentials/differential-detail-page.tsx` * `src/components/services/service-detail-page.tsx`
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Contributor
Author
|
Important Review skippedThis PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
BigSimmo
force-pushed
the
claude/site-formatting-polish-b91374
branch
from
July 11, 2026 15:37
21f9540 to
619dd99
Compare
BigSimmo
merged commit Jul 11, 2026
be5ebd1
into
claude/site-formatting-polish-b91374
3 checks passed
BigSimmo
added a commit
that referenced
this pull request
Jul 11, 2026
* fix(differentials): shape the detail tab focus ring and firm up action taps Rebuilt on top of #483's redesigned interactive detail page (which already fixed the wrapping action labels and tab-label wrap). Remaining polish: - Add a .focus-ring-tab class (inset rounded ring: outline-offset -4px, no halo) so keyboard focus no longer draws a full-height box that collides with the tablist border; inactive tabs get a transparent bottom border to remove the 2px layout jump on tab switch. - Keep #483's roving-tabindex keyboard nav, nowrap and flex-1 layout intact. - shrink-0 on the desktop action cluster so the Save icon button stops being crushed below 44px at ~1024px; nowrap on the Compare button. - Bump the two overlap-diagnosis chips to the 44px tap standard. - Regression test: detail Save action >=44px at 1024px, Overview tab single-line with no page overflow at 320px. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(ui): click-ring artifact and sub-44px tap targets across production routes Still-present defects confirmed by a fresh sweep of current main (15 routes x 7 widths); none were addressed by recent main changes: - DocumentTagCloud: drop the focus: ring classes that painted a ring on mouse click; the global :focus-visible rule keeps the keyboard ring. - applications launcher category filters: mobile 28px / desktop 36px -> 44px, with whitespace-nowrap. - service detail Copy row buttons: 40px -> 44px. - favourites command-library More-actions buttons and library sidebar rows and compact toggle: 36px -> 44px. Deliberately left main's intentional lg:min-h-9 desktop density on the mode-home quick-link pills (AA-compliant for pointer). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(medication): use per-prompt action descriptions on the prescribing home The MedicationHome actions hardcoded description: "Prescribing-focused search." for every prompt, ignoring the authored `medicationPrompts[].description` values ("Check renal dosing…", "Review opioid-use…", "Check maximum dose…") that the prescribing-home responsive test asserts. Restore `description: prompt.description` so each card shows its specific guidance and the advisory UI regression passes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * 📝 Add docstrings to `claude/site-formatting-polish-b91374` (#503) --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docstrings generation was requested by @BigSimmo.
The following files were modified:
src/components/DocumentTagCloud.tsxsrc/components/applications-launcher-page.tsxsrc/components/clinical-dashboard/favourites-command-library-page.tsxsrc/components/clinical-dashboard/favourites-library-nav.tsxsrc/components/differentials/differential-detail-page.tsxsrc/components/services/service-detail-page.tsxThese files were ignored
tests/ui-tools.spec.tsThese file types are not supported
src/app/globals.cssℹ️ Note