Skip to content

Claude/site formatting polish b91374#506

Merged
BigSimmo merged 5 commits into
mainfrom
claude/site-formatting-polish-b91374
Jul 11, 2026
Merged

Claude/site formatting polish b91374#506
BigSimmo merged 5 commits into
mainfrom
claude/site-formatting-polish-b91374

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

Verification

  • npm run verify:pr-local

During development, use npm run verify:cheap as the faster iteration gate before the final PR-local preflight.

  • npm run verify:ui when UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changed
  • npm run verify:release before release or handoff confidence claims

For retrieval, ranking, selection, chunking, source/citation rendering, or answer-contract changes, verify:pr-local runs eval:rag:offline automatically. Run the offline command directly during iteration before spending a live eval.

  • npm run eval:retrieval:quality (must stay 36/36) when retrieval, ranking, selection, chunking, or scoring behavior changed — CI cannot run it (needs live keys), so run it locally and paste the summary. A metadata/governance-weighting change once buried correct docs (recall 1.0→0.76) and only this eval caught it.
  • npm run eval:rag -- --limit 15 + npm run eval:quality -- --rag-only when answer generation, the synthesis prompt, or answer post-processing changed (grounded-supported must not drop; citation-failure 0)
  • npm run check:production-readiness when clinical workflow, privacy, environment, Supabase, source governance, or deployment behavior changed
  • npm run check:deployment-readiness when deployment startup, hosting, or rollout behavior changed

Clinical Governance Preflight

Complete this section when the change touches ingestion, answer generation, search/ranking, source rendering, document access, privacy, production env, or clinical output.

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Notes

BigSimmo and others added 4 commits July 11, 2026 23:33
…n taps

Rebuilt on top of #483's redesigned interactive detail page (which already fixed
the wrapping action labels and tab-label wrap). Remaining polish:

- Add a .focus-ring-tab class (inset rounded ring: outline-offset -4px, no halo)
  so keyboard focus no longer draws a full-height box that collides with the
  tablist border; inactive tabs get a transparent bottom border to remove the
  2px layout jump on tab switch.
- Keep #483's roving-tabindex keyboard nav, nowrap and flex-1 layout intact.
- shrink-0 on the desktop action cluster so the Save icon button stops being
  crushed below 44px at ~1024px; nowrap on the Compare button.
- Bump the two overlap-diagnosis chips to the 44px tap standard.
- Regression test: detail Save action >=44px at 1024px, Overview tab single-line
  with no page overflow at 320px.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…on routes

Still-present defects confirmed by a fresh sweep of current main (15 routes x 7
widths); none were addressed by recent main changes:

- DocumentTagCloud: drop the focus: ring classes that painted a ring on mouse
  click; the global :focus-visible rule keeps the keyboard ring.
- applications launcher category filters: mobile 28px / desktop 36px -> 44px,
  with whitespace-nowrap.
- service detail Copy row buttons: 40px -> 44px.
- favourites command-library More-actions buttons and library sidebar rows and
  compact toggle: 36px -> 44px.

Deliberately left main's intentional lg:min-h-9 desktop density on the mode-home
quick-link pills (AA-compliant for pointer).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…g home

The MedicationHome actions hardcoded description: "Prescribing-focused search."
for every prompt, ignoring the authored `medicationPrompts[].description` values
("Check renal dosing…", "Review opioid-use…", "Check maximum dose…") that the
prescribing-home responsive test asserts. Restore `description: prompt.description`
so each card shows its specific guidance and the advisory UI regression passes.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@supabase

supabase Bot commented Jul 11, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@BigSimmo
BigSimmo enabled auto-merge (squash) July 11, 2026 16:52
@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Added JSDoc comments to eight React components across document tags, applications, favourites, differentials, and services. No executable logic, rendering behavior, or public interfaces changed.

Changes

UI Component Documentation

Layer / File(s) Summary
Component JSDoc annotations
src/components/DocumentTagCloud.tsx, src/components/applications-launcher-page.tsx, src/components/clinical-dashboard/*, src/components/differentials/differential-detail-page.tsx, src/components/services/service-detail-page.tsx
Added comments documenting component purposes, parameters, returns, and supported UI interactions.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 9 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 70.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title hints at formatting polish, but it is too generic to clearly summarize the actual docstring and UI polish changes. Rename it to describe the main change, e.g. "Add documentation comments and UI formatting polish across site components".
✅ Passed checks (9 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Generated And Sensitive Files ✅ Passed Diff only touches six .tsx component files with added JSDoc comments; no secrets, .envs, caches, build outputs, or node_modules artifacts were present.
Verification Claims ✅ Passed Only JSDoc comments were added; the PR template/description has unchecked verification items, not unsupported claims that checks passed.
Risky Git Or Deployment Actions ✅ Passed Touched files only add JSDoc comments; diff search found no force-push/reset/clean/deploy or other destructive workflow instructions.
Supabase Project And Schema Safety ✅ Passed Only JSDoc comments were added in UI components; the PR diff has no Supabase refs, schema changes, migrations, or RLS/policy edits.
Runtime And Package Manager Integrity ✅ Passed PR only adds JSDoc comments in six TSX files; no package.json/lockfile/.npmrc/.nvmrc changes, so Node 24/npm 11 and engine-strict stay intact.
Api Route Failure Handling ✅ Passed Branch diff is comment-only JSDoc updates in six UI components; no API route, server action, RAG, search, ingestion, or provider code changed.
Description check ✅ Passed The description matches the required template headings and checklist structure, with all required sections present.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/site-formatting-polish-b91374
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch claude/site-formatting-polish-b91374

Comment @coderabbitai help to get the list of available commands.

@BigSimmo
BigSimmo merged commit b3411cd into main Jul 11, 2026
15 checks passed
@BigSimmo
BigSimmo deleted the claude/site-formatting-polish-b91374 branch July 13, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant