Remove dead mode-home type tokens superseded by --text-hero#522
Conversation
…-hero PR #517's hybrid-fluid mode-home hero (fluid `--text-hero` clamp + `-minus` card tokens) replaced the only consumer of the stepped named-token set that #512 added for the same off-scale values. Those 7 tokens (--text-xs-plus, -sm-plus, -base-sub, -2xl-sub, -3xl-sub, -3xl-plus, -4xl-minus) are now unused everywhere in src, so remove them and their orphaned scale comment — reconciling the two parallel token sets left after the #517/#512 merge. Verify: prettier, check:type-scale --strict, check:icon-scale, lint, typecheck, and the globals.css merge-artifact guard test all green; the removed tokens have zero references in src (git grep). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe global Tailwind theme removes obsolete mode-home typography documentation and several custom text tokens. Process-hardening documentation now records the shared fluid hero scale, removed aliases, and strict type-scale gate enforcement. ChangesTypography Theme Cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (10 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
Summary
Follow-up cleanup to #517. Removes the dead stepped mode-home type tokens that #512 added, now that #517's hybrid-fluid hero (
--text-heroclamp() + the existing-minustokens) replaced their only consumer.Removed from the
globals.css@themeblock (zero references anywhere insrc— confirmed bygit grep):--text-xs-plus,--text-sm-plus,--text-base-sub,--text-2xl-sub,--text-3xl-sub,--text-3xl-plus,--text-4xl-minus, plus their now-orphaned scale comment.No visual change — those tokens generated
text-*utilities that nothing used. This reconciles the two parallel token sets left after the #517 / #512 merge.Verification
check:type-scale --strict,check:icon-scale, lint, typecheck — all green.globals.cssmerge-artifact guard unit test passes (6/6).git grepconfirms zero usages of the removed tokens across the repo.Clinical governance preflight
N/A — CSS token cleanup only; no ingestion, retrieval, answer generation, source rendering, document access, privacy, or production-config changes.
🤖 Generated with Claude Code