Skip to content

Remove dead mode-home type tokens superseded by --text-hero#522

Merged
BigSimmo merged 2 commits into
mainfrom
claude/reconcile-mode-home-tokens
Jul 12, 2026
Merged

Remove dead mode-home type tokens superseded by --text-hero#522
BigSimmo merged 2 commits into
mainfrom
claude/reconcile-mode-home-tokens

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

Follow-up cleanup to #517. Removes the dead stepped mode-home type tokens that #512 added, now that #517's hybrid-fluid hero (--text-hero clamp() + the existing -minus tokens) replaced their only consumer.

Removed from the globals.css @theme block (zero references anywhere in src — confirmed by git grep):
--text-xs-plus, --text-sm-plus, --text-base-sub, --text-2xl-sub, --text-3xl-sub, --text-3xl-plus, --text-4xl-minus, plus their now-orphaned scale comment.

No visual change — those tokens generated text-* utilities that nothing used. This reconciles the two parallel token sets left after the #517 / #512 merge.

Verification

  • prettier, check:type-scale --strict, check:icon-scale, lint, typecheck — all green.
  • The globals.css merge-artifact guard unit test passes (6/6).
  • git grep confirms zero usages of the removed tokens across the repo.

Clinical governance preflight

N/A — CSS token cleanup only; no ingestion, retrieval, answer generation, source rendering, document access, privacy, or production-config changes.

🤖 Generated with Claude Code

…-hero

PR #517's hybrid-fluid mode-home hero (fluid `--text-hero` clamp + `-minus` card
tokens) replaced the only consumer of the stepped named-token set that #512 added
for the same off-scale values. Those 7 tokens (--text-xs-plus, -sm-plus, -base-sub,
-2xl-sub, -3xl-sub, -3xl-plus, -4xl-minus) are now unused everywhere in src, so
remove them and their orphaned scale comment — reconciling the two parallel token
sets left after the #517/#512 merge.

Verify: prettier, check:type-scale --strict, check:icon-scale, lint, typecheck, and
the globals.css merge-artifact guard test all green; the removed tokens have zero
references in src (git grep).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@supabase

supabase Bot commented Jul 12, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 13a9bd15-1a3c-4798-a555-0526403a5f7a

📥 Commits

Reviewing files that changed from the base of the PR and between 8b3dee8 and 344f10f.

📒 Files selected for processing (1)
  • docs/process-hardening.md

📝 Walkthrough

Summary by CodeRabbit

  • Style

    • Streamlined typography settings by removing unused text-size variants.
    • Retained the shared fluid hero scale for compact layouts.
  • Documentation

    • Updated type-scale guidance to reflect the completed backlog and stricter validation.
    • Clarified that arbitrary text sizes are rejected by the type-scale checks.

Walkthrough

The global Tailwind theme removes obsolete mode-home typography documentation and several custom text tokens. Process-hardening documentation now records the shared fluid hero scale, removed aliases, and strict type-scale gate enforcement.

Changes

Typography Theme Cleanup

Layer / File(s) Summary
Remove obsolete text tokens
src/app/globals.css
Removes the mode-home typography comment block and selected *-plus, *-sub, and 4xl-minus theme tokens from the @theme text scale.
Update type-scale ratchet documentation
docs/process-hardening.md
Documents the shared fluid --text-hero scale, removed mode-home aliases, strict-gate result, and verify:cheap enforcement.

Estimated code review effort: 1 (Trivial) | ~2 minutes


Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Verification Claims ❌ Error PR description says “prettier, check:type-scale --strict, check:icon-scale, lint, typecheck — all green,” which is a vague verification claim, not exact run/result wording. Rewrite verification notes as exact command/result pairs, e.g. “Ran npm run verify:cheap: passed” or “Not run: reason.”
✅ Passed checks (10 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately describes the main change: removing unused mode-home type tokens.
Description check ✅ Passed The description is mostly complete, with summary, verification, and governance notes that match the template's intent.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Generated And Sensitive Files ✅ Passed Branch diff vs base only changes src/app/globals.css and docs/process-hardening.md; no secrets, .env files, caches, build outputs, or other risky artifacts found.
Risky Git Or Deployment Actions ✅ Passed Only a type-scale docs note changed; no force-push, reset --hard, destructive clean, rebase, or unsafe deploy guidance was added.
Supabase Project And Schema Safety ✅ Passed Only a docs note changed; no Supabase project refs, env examples, migrations, RLS/policy, or schema/data changes were introduced.
Runtime And Package Manager Integrity ✅ Passed Diff only touches docs/process-hardening.md; no package-manager, lockfile, engines, engine-strict, or force/legacy-resolution changes, and repo stays on npm 11/Node 24.
Api Route Failure Handling ✅ Passed PR only changes CSS/docs; no API route, server action, RAG, search, ingestion, or provider integration code to evaluate for failure handling.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/reconcile-mode-home-tokens
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch claude/reconcile-mode-home-tokens

Comment @coderabbitai help to get the list of available commands.

@BigSimmo
BigSimmo enabled auto-merge (squash) July 12, 2026 17:30
@BigSimmo
BigSimmo merged commit a4ed305 into main Jul 12, 2026
15 checks passed
@BigSimmo
BigSimmo deleted the claude/reconcile-mode-home-tokens branch July 13, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant