Sizing: fluid mode-home hero + shared content-page container#517
Conversation
…ints Perfect the mode-home hero sizing (Home / services / forms / differentials / favourites / applications) with hybrid-fluid typography: - add fluid `--text-hero` clamp() token so the display heading scales smoothly ~23px->34px with no breakpoint jumps; floor pinned to 1.45rem to preserve the 390px hero-metrics baseline - collapse ModeHomeHero's dual sizing mechanism: remove the dead `compact` prop (all three consumers passed it) for clean mobile-first stepped icon/gaps plus the fluid heading - replace off-scale one-off text sizes (subtitle, card title/description) with named scale tokens; clears the last arbitrary text-[...] so check:type-scale --strict is clean repo-wide - align the loading skeleton to the refactored hero to remove load-time layout shift (max-w 64rem->60rem, icon/heading/composer dimensions) Verify: typecheck, lint, check:type-scale --strict, 1648 unit tests, and the chromium mode-home hero tests green; visual capture 320-1280 confirms smooth scaling with no horizontal overflow. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…fix form-detail h1 App-wide sizing consistency (follow-on to the mode-home hero pass): - add `pageContainer` recipe (mx-auto w-full max-w-7xl) as the single source of truth for the content-page reading width; adopt byte-identically across the max-w-7xl cluster: service / form / differential detail, medication record + prescribing workspace, forms results - fix form-detail h1 outlier: text-xl -> text-3xl on mobile (was 20px vs the 30px every sibling detail page uses), leading aligned to 1.05 Intentionally-wider surfaces (document viewer 1440px, differentials tables) and the hot ClinicalDashboard / DocumentViewer / header files keep their current widths; the header-height magic-number token and tap-target density work are deferred to a dedicated coordinated pass. Verify: prettier, typecheck, lint, check:type-scale --strict, 1648 unit tests green; visual capture of /forms/[slug] at 390/1280 confirms the h1 and container. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reached
Next review available in: 20 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR centralizes page container styling, adds fluid hero typography, standardizes the Mode Home hero API and presentation, updates related call sites, and adjusts Mode Home loading skeleton dimensions. ChangesLayout and Mode Home updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error, 1 warning)
✅ Passed checks (9 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
Resolve the mode-home-template.tsx conflict: another merged PR retokenized the mode-home hero + card sizes onto a stepped named-token scale (text-3xl-plus / text-2xl-sub / text-base-sub / text-xs-plus …) while keeping the `compact` prop. This branch keeps its approved hybrid-fluid treatment instead — fluid `text-hero` clamp() for the heading, `compact` removed, and consistent card title/description tokens (fixing the inverted mobile>desktop card title). main's new --text-* tokens are retained in globals.css (harmless; the two token sets can be reconciled later).
* refactor(type-scale): drop dead mode-home tokens superseded by --text-hero PR #517's hybrid-fluid mode-home hero (fluid `--text-hero` clamp + `-minus` card tokens) replaced the only consumer of the stepped named-token set that #512 added for the same off-scale values. Those 7 tokens (--text-xs-plus, -sm-plus, -base-sub, -2xl-sub, -3xl-sub, -3xl-plus, -4xl-minus) are now unused everywhere in src, so remove them and their orphaned scale comment — reconciling the two parallel token sets left after the #517/#512 merge. Verify: prettier, check:type-scale --strict, check:icon-scale, lint, typecheck, and the globals.css merge-artifact guard test all green; the removed tokens have zero references in src (git grep). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * docs: reconcile retired mode-home tokens --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Summary
Two sizing slices (Home-first, then app-wide container). UI-only — no logic, data-flow, routing, ingestion, answer-generation, or clinical-output changes.
Slice 1 — mode-home hero (hybrid-fluid)
--text-heroclamp()token: the hero heading scales smoothly ~23px→34px across viewports with no breakpoint jumps (floor pinned to1.45remso the 390px hero-metrics baseline is unchanged).ModeHomeHero's dual sizing mechanism — removed the deadcompactfork (all three consumers passed it) for clean mobile-first stepped icon/gaps.text-[…]socheck:type-scale --strictis clean repo-wide.Slice 2 — content-page container unification
pageContainerrecipe (mx-auto w-full max-w-7xl) as the single source of truth for content-page width; adopted byte-identically across themax-w-7xlcluster (service / form / differential detail, medication record + prescribing workspace, forms results).text-xl → text-3xlon mobile (was 20px vs the 30px every sibling detail page uses).Deliberately deferred
Intentionally-wider surfaces (document viewer 1440px, differentials tables) and the hot
ClinicalDashboard/DocumentViewer/ header files keep their current widths. The header-height magic-number token (values are genuinely inconsistent —4/4.75/3.5rem) and the services-navigator tap-target density work are left for a dedicated, coordinated pass.Verification
typecheck,lint,check:type-scale --strict, 1648 unit tests, prettier — all green./forms/[slug]at 390 / 1280.Clinical governance preflight
N/A — UI sizing only; no ingestion, retrieval/ranking, answer generation, source rendering, document access, privacy, or production-config changes.
🤖 Generated with Claude Code