ci: make production-journey UI regression blocking, isolate mockup specs (PT-05)#592
Conversation
…ecs (PT-05) The advisory UI regression job could stay red while pr-required stayed green, letting production-journey failures normalise. Split Playwright chromium into a production-journey project and a chromium-mockups project (prototype /mockups specs), promote ui-regression into pr-required (same ui_changed gating as ui-critical so merge-queue runs are covered), and keep mockups advisory in a new ui-mockups job. firefox/webkit release-matrix coverage is unchanged. Proof for the promotion: production-journey suite 135/135 locally after hardening the one flake - the cross-mode quick-link click, where the app-router URL only commits once /medications/[slug] responds and a cold dev compile takes ~30s when the @critical warm-up journeys are excluded; the spec now re-clicks inside a 45s toPass window. PT-17 (scheduled live-domain monitoring) is deliberately not included: it targets production and needs explicit approval. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reached
Next review available in: 9 seconds Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe PR separates production and mockup Playwright tests, adds mockup npm scripts and tags, and introduces an advisory CI lane for mockup E2E coverage. It also adjusts two UI smoke flows for route timing and removes redundant navigation assertions. ChangesMockup UI testing
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 19e176a329
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. After fixing or dispositioning a thread, reply in that thread with as the first line, followed by a concise summary; that marker authorizes the workflow to close that exact thread. If human input or new authorization is required, do not use the marker and leave the thread open with the blocker. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation. |
|
To use Codex here, create a Codex account and connect to github. |
#593 already promoted ui-regression (test:e2e:regression with the @quarantine escape hatch); this branch keeps only its unique delta — the chromium-mockups project split, the advisory ui-mockups lane, and the cross-mode spec hardening. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b89482924
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 352-380: Replace the mutable version tags for the actions used in
the Chromium mockup job—checkout, setup-node, cache, and upload-artifact—with
their full trusted commit SHAs, retaining comments that identify the
corresponding action versions for maintainability. Do not alter the job’s
existing behavior or configuration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: cf431dd5-e634-4dad-b1da-55d203f667fc
📒 Files selected for processing (7)
.github/workflows/ci.ymlpackage.jsonplaywright.config.tstests/ui-smoke.spec.tstests/ui-tools-collapse.spec.tstests/ui-tools-task-directory.spec.tstests/ui-tools.spec.ts
# Conflicts: # tests/ui-tools-collapse.spec.ts
# Conflicts: # .github/workflows/ci.yml
1 participant
Summary
Audit PT-05: the advisory UI regression job could stay red while
pr-requiredstayed green, letting production-journey failures normalise.chromium) and achromium-mockupsproject (prototype/mockupsspecs:ui-tools-collapse,ui-tools-task-directory); the patterns are disjoint and their union equals the legacy testMatch, so firefox/webkit release-matrix coverage is unchanged.ui-regressionis promoted intopr-required(sameui_changedgating asui-critical, so merge-queue runs are covered) and losescontinue-on-error.ui-mockupsjob./medications/[slug]responds and a cold dev compile takes ~30s when the@criticalwarm-up journeys are excluded; the spec now re-clicks inside a 45stoPasswindow.Verification
Production-journey suite 135/135 locally after the hardening; mockup project 7/7;
check:ci-scopeself-test, GitHub Actions pin check, prettier green.PT-17 (scheduled live-domain monitoring) is deliberately not included — it targets production and needs explicit approval.
🤖 Generated with Claude Code
Summary by CodeRabbit
Testing
CI