CI: include answer-progress Playwright journey in production UI gate#748
CI: include answer-progress Playwright journey in production UI gate#748BigSimmo wants to merge 3 commits into
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reached
Next review available in: 35 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR updates CI change classification and Playwright filename matching so the answer-progress UI journey and additional tools UI specs are included in UI verification. A review ledger entry records the prior CI coverage gap and validation results. ChangesCI UI coverage
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@copilot resolve the merge conflicts in this pull request |
Head branch was pushed to by a user without write access
Resolved the merge conflicts by merging |
Merge conflict resolved in commit The PR policy CI check is still failing because the PR description uses ## Summary
Add `tests/answer-progress-ui-smoke.spec.ts` to the production Playwright UI gate and CI change-scope classifier. Previously the spec was excluded from both `playwright.config.ts` matchers and `ci-change-scope.mjs` UI patterns, creating a verification gap where assertion edits would not trigger the required Chromium UI job.
## Verification
- [x] `node scripts/ci-change-scope.mjs --self-test` — passed (new `answer-progress-playwright` assertion exercised)
- [x] `node scripts/ci-change-scope.mjs --json --files tests/answer-progress-ui-smoke.spec.ts` — reports `ui_changed: true`
- [x] `npm run verify:cheap`
- [x] `npm run verify:pr-local -- --files playwright.config.ts,scripts/ci-change-scope.mjs`
UI verification not run: browser assertions did not complete due to Google-hosted font download failures in this environment; hosted CI Chromium run required.
## Risk and rollout
- Risk: low; CI-only change affecting test selection and classification only. No runtime application behavior is changed.
- Rollback: revert this PR's single commit.
- Provider or production effects: None |
…ation-system-in-bigsimmo
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #3011 (success). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
Motivation
Description
playwright.config.tsso theproductionSpecPatternandtestMatchincludetests/answer-progress-ui-smoke.spec.ts.tests/answer-progress-ui-smoke.spec.tstouiPatternsinscripts/ci-change-scope.mjsand adding a self-test assertionanswer-progress-playwrightto the script'sselfTest.docs/branch-review-ledger.mdso the change and its limited local verification are visible in the review ledger.playwright.config.ts,scripts/ci-change-scope.mjs,docs/branch-review-ledger.md.Testing
node scripts/ci-change-scope.mjs --self-testand it passed, exercising the newanswer-progress-playwrightassertion.node scripts/ci-change-scope.mjs --json --files tests/answer-progress-ui-smoke.spec.tsand it now reportsui_changed: true, proving the classifier will trigger the Production UI job for edits to that spec.npm run verify:cheapandnpm run verify:pr-local -- --files playwright.config.ts,scripts/ci-change-scope.mjs, both completed in the environment used for this change.tests/answer-progress-ui-smoke.spec.tsbut the isolated Next production build could not complete browser verification here because required Google-hosted font downloads failed in this environment, so the browser assertions did not reach completion; hosted CI/provider-backed UI runs remain required to fully validate the Playwright journey.Notes: hosted CI and provider-backed checks were not executed per repository policy for local verification; the change is limited to test/CI selection and does not alter runtime application behavior.
Codex Task
Summary by CodeRabbit