feat(ux): labelled sidebar default and Forms early-access signalling (PT-07, PT-10)#598
Conversation
…ckup tile a11y (PT-07, PT-10, PT-15)
New users now get the labelled (expanded) desktop sidebar: eight
icon-only destinations demand recall and hover; collapsing remains a
remembered per-browser choice, and specs that exercise the collapsed
rail seed that preference explicitly. Tablet keeps the icon rail.
Forms is a four-record starter catalogue, so signal maturity honestly:
an "Early access" pill on the sidebar entry (spoken in the collapsed
rail label too) and an early-access line in the Forms home subtitle.
Give the split-pane mockup's selectable tool cards a concise accessible
name ("Open <tool>") matching their link-rendered siblings, and tighten
the spec to assert it.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The expanded sidebar's "Search recent chats" box becomes the first searchbox on shell-wrapped pages, so mockup collapse specs scope their search to #main-content. The tablet rail assertion moves from DOM-absence to hidden (the expanded panel now exists but stays display:none below lg), and the rail's Forms link is asserted with its spoken "Forms (Early access)" name. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reached
Next review available in: 4 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe clinical sidebar now defaults to expanded for new or unavailable persistence states. The Forms tool displays an “Early access” badge, and forms messaging reflects the starter set. UI tests cover updated expanded, collapsed, tablet, account, and search behavior. ChangesClinical sidebar experience
Estimated code review effort: 3 (Moderate) | ~20 minutes Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (10 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fba18eb02a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. After fixing or dispositioning a thread, reply in that thread with as the first line, followed by a concise summary; that marker authorizes the workflow to close that exact thread. If human input or new authorization is required, do not use the marker and leave the thread open with the blocker. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation. |
|
To use Codex here, create a Codex account and connect to github. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/clinical-dashboard/use-sidebar-collapsed.ts`:
- Around line 14-15: Update the storage-write error path in setCollapsed so it
records the requested collapsed state in an in-memory fallback snapshot when
localStorage writes fail. Ensure getSnapshot reads this volatile value before
falling back to localStorage/default state, while preserving persistence
behavior when storage writes succeed and the existing change-event dispatch.
🪄 Autofix (Beta)
✅ Autofix completed
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 1156a2da-0168-4d32-9188-d38687028ac0
📒 Files selected for processing (6)
src/components/clinical-dashboard/ClinicalSidebar.tsxsrc/components/clinical-dashboard/use-sidebar-collapsed.tssrc/components/forms/forms-home-page.tsxtests/ui-smoke.spec.tstests/ui-tools-collapse.spec.tstests/ui-tools.spec.ts
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. Fixes Applied SuccessfullyFixed 1 file(s) based on 1 unresolved review comment. Files modified:
Commit: The changes have been pushed to the Time taken: |
Fixed 1 file(s) based on 1 unresolved review comment. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
1 participant
Summary
Audit PT-07 / PT-10 (PT-15's accessible names landed in #582):
#main-content.Visual QA: screenshots at 320/360/375/390/430/768/1024/1280/1440 px show zero horizontal overflow; the audit's PT-08/PT-09 mobile-clipping and desktop-spacing claims did not reproduce on current main (chips use the standard scroll-peek + edge fade; the home was reworked by #496/#517).
Verification
Targeted Chromium runs green: labelled-default spec, collapsed-rail journey, tablet icon rail (@critical), account affordances, all three mockup collapse specs. Full typecheck, lint, prettier green.
🤖 Generated with Claude Code