Skip to content

Place Also matches panel after primary search results#797

Closed
BigSimmo wants to merge 11 commits into
mainfrom
cursor/also-matches-placement-db17
Closed

Place Also matches panel after primary search results#797
BigSimmo wants to merge 11 commits into
mainfrom
cursor/also-matches-placement-db17

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Jul 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • Moves the UniversalSearchAlsoMatches cross-mode panel to render after primary results across affected mode pages, resolving visual confusion when cross-mode matches competed with the primary hit list.
  • Adds a Playwright regression test asserting DOM placement relative to primary results.
  • Supersedes Place 'Also matches in other modes' panel after primary results #749 (original blocked on PR policy; format and UI test fixes already landed on the branch).

Verification

  • Hosted Build / Unit coverage / Advisory UI evidence on the predecessor head.
  • npm run verify:ui evidence via hosted Production UI after the placement-test fix.
  • UI verification not run locally in this babysit pass: relying on hosted Production UI.

Risk and rollout

  • Risk: low; UI-only DOM reordering within existing search-mode pages — no data, API, or clinical logic changes.
  • Rollback: revert this PR; cross-mode panel returns to its previous position.
  • Provider or production effects: None

Clinical Governance Preflight

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed
Open in Web Open in Cursor 

BigSimmo and others added 7 commits July 18, 2026 03:26
@BigSimmo
fix: place cross-mode matches after results
1d07cad
@BigSimmo
Merge branch 'main' into codex/fix-related-options-placement-bug
3d5f887
test: add descriptive failure message to DOM-order assertion
62c830d
fix: resolve TS2532 null-safety error in DOM-order assertion
1cdf3df
@cursoragent
fix: format document-search-results.tsx (prettier)
35980cc
@cursoragent
fix(test): use service-matching query in placement test and fix TS2532
7c0952e 
The placement test navigated to /services?q=acamprosate&run=1. Since
'acamprosate' matches no service fixtures, displayedMatches is empty
and the empty-state renders instead of the service-search-results div,
causing expect(results).toBeVisible() to time out.

Fix: route the test through an inline mock that echoes the request query
back as the universal-search response query (so universal-also-matches
renders), and navigate to q=13YARN which matches the demo service
fixture records so service-search-results is present.

Also fixes pre-existing TS2532: add ?? 0 fallback before the bitwise &
to resolve the 'Object is possibly undefined' error from optional chaining.
@cursoragent
Merge remote-tracking branch 'origin/main' into codex/fix-related-opt…
6b1fcdc 
…ions-placement-bug
@supabase

supabase Bot commented Jul 17, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@cursor[bot], you've reached your PR review limit, so we couldn't start this review.

Next review available in: 15 seconds

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f36bd060-edfa-40fe-9056-4cb289accc0f

📥 Commits

Reviewing files that changed from the base of the PR and between 3ff8095 and aafab49.

📒 Files selected for processing (8)
  • src/components/clinical-dashboard/differentials-home.tsx
  • src/components/clinical-dashboard/document-search-results.tsx
  • src/components/clinical-dashboard/favourites-command-library-page.tsx
  • src/components/clinical-dashboard/medication-prescribing-workspace.tsx
  • src/components/forms/forms-search-results-page.tsx
  • src/components/formulation/formulation-home-page.tsx
  • src/components/services/services-navigator-page.tsx
  • tests/ui-universal-search.spec.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/also-matches-placement-db17

Comment @coderabbitai help to get the list of available commands.

@cursor
cursor Bot enabled auto-merge (squash) July 17, 2026 20:36
@BigSimmo BigSimmo mentioned this pull request Jul 18, 2026
Merged
11 tasks
@cursor

cursor Bot commented Jul 18, 2026

Copy link
Copy Markdown

Superseded by merged #808, which ports Also matches placement after primary results onto current main. Please close this PR.

@BigSimmo BigSimmo closed this Jul 18, 2026
auto-merge was automatically disabled July 18, 2026 06:22

Pull request was closed

@BigSimmo BigSimmo mentioned this pull request Jul 18, 2026
Merged
8 tasks
@BigSimmo
BigSimmo deleted the cursor/also-matches-placement-db17 branch July 18, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BigSimmo @cursoragent