fix: finish screenshot-PR residuals (Also matches order + error focus)#812
Merged
Conversation
Keep tools/favourites Also matches after primary hub content so the panel matches the post-results placement landed from the screenshot queue, and use focus: styles on the route error heading so recovery focus remains visible after pointer-driven failures. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Contributor
📝 WalkthroughWalkthroughThis change makes search error messaging mode-aware, broadens ChangesUniversal search rendering
Route error focus styling
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
BigSimmo
marked this pull request as ready for review
July 18, 2026 06:27
CodeRabbit residual from superseded #802: non-answer modes should not show "Answer unavailable" for document-search/clipboard failures. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
9 tasks
9 tasks
1 task
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UniversalSearchAlsoMatchesrendering to after primary mode hub content inClinicalDashboard, matching the post-results placement landed from the screenshot PR queue (Place Also matches panel after primary search results #797 via fix: land unique open-PR queue onto current main #808).focus-visible:tofocus:so programmatic recovery focus remains visible after pointer-driven failures (CodeRabbit finding on superseded fix: harden Therapy Compass recovery and error accessibility #800).Answer unavailablevsSearch unavailable) from superseded fix: unify answer recovery states with shared EmptyState #802 review feedback.Verification
npm run test:focused -- --files src/components/route-error-boundary.tsx,src/components/ClinicalDashboard.tsx(5 passed)Risk and rollout
Clinical Governance Preflight
Clinical KB Database(sjrfecxgysukkwxsowpy)Notes
Summary by CodeRabbit