Skip to content

fix: finish screenshot-PR residuals (Also matches order + error focus)#812

Merged
cursor[bot] merged 2 commits into
mainfrom
cursor/pr-queue-residuals-8807
Jul 18, 2026
Merged

fix: finish screenshot-PR residuals (Also matches order + error focus)#812
cursor[bot] merged 2 commits into
mainfrom
cursor/pr-queue-residuals-8807

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Jul 18, 2026

Copy link
Copy Markdown
Owner

Summary

Verification

  • npm run test:focused -- --files src/components/route-error-boundary.tsx,src/components/ClinicalDashboard.tsx (5 passed)
  • UI verification not run: change is DOM order + focus utility class + EmptyState title string only; hosted Production UI covers the affected dashboard paths
  • Hosted CI: Static / Unit / Production UI as required by change scope

Risk and rollout

  • Risk: low — DOM order for Also matches on tools/favourites, a11y focus ring on error recovery, and mode-specific error titles
  • Rollback: revert this squash merge
  • Provider or production effects: None

Clinical Governance Preflight

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Notes

Open in Web Open in Cursor 

Summary by CodeRabbit

  • Bug Fixes
    • Improved how “also matches” results are displayed by ensuring they appear consistently across answer and non-answer views.
    • Made the route error heading more consistent for keyboard users by adjusting focus styling.
    • Updated the error fallback messaging to be mode-aware, showing the appropriate “unavailable” title depending on the current view.

Keep tools/favourites Also matches after primary hub content so the
panel matches the post-results placement landed from the screenshot
queue, and use focus: styles on the route error heading so recovery
focus remains visible after pointer-driven failures.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@supabase

supabase Bot commented Jul 18, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This change makes search error messaging mode-aware, broadens UniversalSearchAlsoMatches rendering based on its visibility flag, and changes route error heading focus styling from focus-visible to focus utilities.

Changes

Universal search rendering

Layer / File(s) Summary
Universal search match and error rendering
src/components/ClinicalDashboard.tsx
Unavailable errors now distinguish answer and search modes, while UniversalSearchAlsoMatches renders based solely on showUniversalAlsoMatches.

Route error focus styling

Layer / File(s) Summary
Error heading focus styling
src/components/route-error-boundary.tsx
The error heading uses focus:outline* utilities instead of focus-visible:outline* utilities.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested labels: codex

Suggested reviewers: claude, cursoragent

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title is specific and matches the main UI fixes, including Also matches ordering and focus/error behavior.
Description check ✅ Passed The description follows the template and includes summary, verification, risk, and clinical governance sections.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/pr-queue-residuals-8807

Comment @coderabbitai help to get the list of available commands.

@BigSimmo
BigSimmo marked this pull request as ready for review July 18, 2026 06:27
@cursor
cursor Bot enabled auto-merge (squash) July 18, 2026 06:28
CodeRabbit residual from superseded #802: non-answer modes should not
show "Answer unavailable" for document-search/clipboard failures.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@cursor
cursor Bot merged commit 77ab4a6 into main Jul 18, 2026
16 of 17 checks passed
@cursor
cursor Bot deleted the cursor/pr-queue-residuals-8807 branch July 18, 2026 06:37
cursor Bot pushed a commit that referenced this pull request Jul 18, 2026
Capture the #808/#812/#814 consolidation and closed superseding heads so
future branch-review passes skip the unchanged closed screenshot PRs.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
cursor Bot pushed a commit that referenced this pull request Jul 18, 2026
Capture the #808/#812/#814 consolidation and closed superseding heads so
future branch-review passes skip the unchanged closed screenshot PRs.

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants