Harden document-mode smoke switching follow-up

[Copilot]

Summary

• Address the remaining PR [codex] Update clinical guide for Node 24 #78 review follow-up by making document-mode smoke coverage fail fast when no supported mode switch control is present.
• Keep compatibility with both the legacy mode toggle and the newer app-mode menu path without widening production behavior.

Verification

• npm run verify:cheap
• npm run verify:ui when UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changed
• npm run verify:release before release or handoff confidence claims
• npm run format:check
• npm run check:production-readiness when clinical workflow, privacy, environment, Supabase, source governance, or deployment behavior changed

Clinical Governance Preflight

Complete this section when the change touches ingestion, answer generation, search/ranking, source rendering, document access, privacy, production env, or clinical output.

• Source-backed claims still require linked source verification before clinical use
• No patient-identifiable document workflow was introduced or expanded without explicit governance approval
• Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
• Service-role keys and private document access remain server-only
• Demo/synthetic content remains clearly separated from real clinical sources
• Source metadata, review status, and outdated/unknown-source behavior remain conservative
• Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Notes

• Smoke helper hardening

  • preserve both supported mode-switch paths
  • fail immediately with a clear error when neither control is available
  • tighten menu-item selection and reuse locators to reduce ambiguity

• Scope

  • follow-up is limited to tests/ui-smoke.spec.ts
  • DocumentViewer.tsx no longer carries the stale DocumentBadge import

async function switchToDocumentSearchMode(page: Page) {
  const legacyDocumentsMode = page.getByRole("button", { name: "Switch to document search mode" });
  if (await isVisibleWithoutThrow(legacyDocumentsMode)) return useLegacyToggle();

  const appModeMenu = page.getByRole("button", { name: /^Current app mode:/ });
  if (!(await isVisibleWithoutThrow(appModeMenu))) {
    throw new Error(
      "Could not switch to document search mode: neither the legacy mode toggle nor the app mode menu is visible.",
    );
  }

  return useModeMenu();
}

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[Copilot]

Pull request overview

This PR hardens the Playwright UI smoke helper that switches the dashboard into “Documents” mode by supporting both the legacy toggle and a newer “current app mode” menu path, and failing fast with a clear error when neither control is available.

Changes:

• Add a small isVisibleWithoutThrow() helper to probe locator visibility without strict-mode exceptions aborting the flow.
• Update switchToDocumentSearchMode() to (1) use the legacy toggle when present, otherwise (2) fall back to the app-mode menu, and (3) throw a clear error when neither control is visible.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.